From mboxrd@z Thu Jan 1 00:00:00 1970 From: sameo@linux.intel.com (Samuel Ortiz) Date: Fri, 5 Apr 2013 18:39:58 +0200 Subject: [PATCH v4 04/14] mfd: Add Samsung PWM/timer master driver In-Reply-To: <1365093431-30621-5-git-send-email-t.figa@samsung.com> References: <1365093431-30621-1-git-send-email-t.figa@samsung.com> <1365093431-30621-5-git-send-email-t.figa@samsung.com> Message-ID: <20130405163958.GP17363@zurbaran> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Tomasz, On Thu, Apr 04, 2013 at 06:37:01PM +0200, Tomasz Figa wrote: > This patch adds master driver for PWM/timer block available on many > Samsung SoCs providing clocksource and PWM output capabilities. > > Signed-off-by: Tomasz Figa > Signed-off-by: Kyungmin Park > --- > .../devicetree/bindings/pwm/pwm-samsung.txt | 37 ++ > drivers/clocksource/Kconfig | 1 + > drivers/mfd/Kconfig | 3 + > drivers/mfd/Makefile | 1 + > drivers/mfd/samsung-pwm.c | 439 +++++++++++++++++++++ > drivers/pwm/Kconfig | 1 + > include/linux/mfd/samsung-pwm.h | 49 +++ > include/linux/platform_data/samsung-pwm.h | 28 ++ > 8 files changed, 559 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pwm/pwm-samsung.txt > create mode 100644 drivers/mfd/samsung-pwm.c > create mode 100644 include/linux/mfd/samsung-pwm.h > create mode 100644 include/linux/platform_data/samsung-pwm.h Why is that an MFD driver, and why aren't you using the PWM APIs for it ? Also, you probably want to look at using the regmap APIs for your IO. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/