linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: imx23-olinuxino: Set the sdcard as non-removable
@ 2013-04-05  4:16 Alexandre Pereira da Silva
  2013-04-05  6:38 ` Marek Vasut
  2013-04-05  9:16 ` Shawn Guo
  0 siblings, 2 replies; 6+ messages in thread
From: Alexandre Pereira da Silva @ 2013-04-05  4:16 UTC (permalink / raw)
  To: linux-arm-kernel

The imx23-olinuxino sdcard doesn't support card detect.

Signed-off-by: Alexandre Pereira da Silva <aletes.xgr@gmail.com>
---
 arch/arm/boot/dts/imx23-olinuxino.dts |    1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/imx23-olinuxino.dts b/arch/arm/boot/dts/imx23-olinuxino.dts
index e7484e4..03f55c2 100644
--- a/arch/arm/boot/dts/imx23-olinuxino.dts
+++ b/arch/arm/boot/dts/imx23-olinuxino.dts
@@ -29,6 +29,7 @@
 				pinctrl-names = "default";
 				pinctrl-0 = <&mmc0_4bit_pins_a &mmc0_pins_fixup>;
 				bus-width = <4>;
+				non-removable;
 				status = "okay";
 			};
 
-- 
1.7.10

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH] ARM: dts: imx23-olinuxino: Set the sdcard as non-removable
  2013-04-05  4:16 [PATCH] ARM: dts: imx23-olinuxino: Set the sdcard as non-removable Alexandre Pereira da Silva
@ 2013-04-05  6:38 ` Marek Vasut
  2013-04-05  9:16 ` Shawn Guo
  1 sibling, 0 replies; 6+ messages in thread
From: Marek Vasut @ 2013-04-05  6:38 UTC (permalink / raw)
  To: linux-arm-kernel

Dear Alexandre Pereira da Silva,

> The imx23-olinuxino sdcard doesn't support card detect.
> 
> Signed-off-by: Alexandre Pereira da Silva <aletes.xgr@gmail.com>
> ---
>  arch/arm/boot/dts/imx23-olinuxino.dts |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/imx23-olinuxino.dts
> b/arch/arm/boot/dts/imx23-olinuxino.dts index e7484e4..03f55c2 100644
> --- a/arch/arm/boot/dts/imx23-olinuxino.dts
> +++ b/arch/arm/boot/dts/imx23-olinuxino.dts
> @@ -29,6 +29,7 @@
>  				pinctrl-names = "default";
>  				pinctrl-0 = <&mmc0_4bit_pins_a 
&mmc0_pins_fixup>;
>  				bus-width = <4>;
> +				non-removable;
>  				status = "okay";
>  			};

The card on mx23 olinuxino seems perfectly removable to me ... on all possible 
models and even prototypes and hybrids too ;-)

Best regards,
Marek Vasut

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] ARM: dts: imx23-olinuxino: Set the sdcard as non-removable
  2013-04-05  4:16 [PATCH] ARM: dts: imx23-olinuxino: Set the sdcard as non-removable Alexandre Pereira da Silva
  2013-04-05  6:38 ` Marek Vasut
@ 2013-04-05  9:16 ` Shawn Guo
  2013-04-05 14:11   ` Marek Vasut
  1 sibling, 1 reply; 6+ messages in thread
From: Shawn Guo @ 2013-04-05  9:16 UTC (permalink / raw)
  To: linux-arm-kernel

On Fri, Apr 05, 2013 at 01:16:53AM -0300, Alexandre Pereira da Silva wrote:
> The imx23-olinuxino sdcard doesn't support card detect.
> 
So it sounds more like a "broken-cd" rather than "non-removable"?

Shawn

> Signed-off-by: Alexandre Pereira da Silva <aletes.xgr@gmail.com>
> ---
>  arch/arm/boot/dts/imx23-olinuxino.dts |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/imx23-olinuxino.dts b/arch/arm/boot/dts/imx23-olinuxino.dts
> index e7484e4..03f55c2 100644
> --- a/arch/arm/boot/dts/imx23-olinuxino.dts
> +++ b/arch/arm/boot/dts/imx23-olinuxino.dts
> @@ -29,6 +29,7 @@
>  				pinctrl-names = "default";
>  				pinctrl-0 = <&mmc0_4bit_pins_a &mmc0_pins_fixup>;
>  				bus-width = <4>;
> +				non-removable;
>  				status = "okay";
>  			};
>  
> -- 
> 1.7.10
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] ARM: dts: imx23-olinuxino: Set the sdcard as non-removable
  2013-04-05  9:16 ` Shawn Guo
@ 2013-04-05 14:11   ` Marek Vasut
  2013-04-05 14:53     ` Alexandre Pereira da Silva
  0 siblings, 1 reply; 6+ messages in thread
From: Marek Vasut @ 2013-04-05 14:11 UTC (permalink / raw)
  To: linux-arm-kernel

Dear Shawn Guo,

> On Fri, Apr 05, 2013 at 01:16:53AM -0300, Alexandre Pereira da Silva wrote:
> > The imx23-olinuxino sdcard doesn't support card detect.
> 
> So it sounds more like a "broken-cd" rather than "non-removable"?

The CD line is working perfectly well on this board, so I don't get it.

Best regards,
Marek Vasut

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] ARM: dts: imx23-olinuxino: Set the sdcard as non-removable
  2013-04-05 14:11   ` Marek Vasut
@ 2013-04-05 14:53     ` Alexandre Pereira da Silva
  2013-04-05 16:08       ` Marek Vasut
  0 siblings, 1 reply; 6+ messages in thread
From: Alexandre Pereira da Silva @ 2013-04-05 14:53 UTC (permalink / raw)
  To: linux-arm-kernel

On Fri, Apr 5, 2013 at 11:11 AM, Marek Vasut <marex@denx.de> wrote:
> The CD line is working perfectly well on this board, so I don't get it.

In the schematics of this board, the SSP1_DETECT pin is connected to
the green led. As I see, there is no way, the hardware can detect card
removal. Am I missing something here?

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] ARM: dts: imx23-olinuxino: Set the sdcard as non-removable
  2013-04-05 14:53     ` Alexandre Pereira da Silva
@ 2013-04-05 16:08       ` Marek Vasut
  0 siblings, 0 replies; 6+ messages in thread
From: Marek Vasut @ 2013-04-05 16:08 UTC (permalink / raw)
  To: linux-arm-kernel

Dear Alexandre Pereira da Silva,

> On Fri, Apr 5, 2013 at 11:11 AM, Marek Vasut <marex@denx.de> wrote:
> > The CD line is working perfectly well on this board, so I don't get it.
> 
> In the schematics of this board, the SSP1_DETECT pin is connected to
> the green led. As I see, there is no way, the hardware can detect card
> removal. Am I missing something here?

You're right. Then the design is indeed defective. Sorry.

Best regards,
Marek Vasut

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2013-04-05 16:08 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-05  4:16 [PATCH] ARM: dts: imx23-olinuxino: Set the sdcard as non-removable Alexandre Pereira da Silva
2013-04-05  6:38 ` Marek Vasut
2013-04-05  9:16 ` Shawn Guo
2013-04-05 14:11   ` Marek Vasut
2013-04-05 14:53     ` Alexandre Pereira da Silva
2013-04-05 16:08       ` Marek Vasut

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).