From: ezequiel.garcia@free-electrons.com (Ezequiel Garcia)
To: linux-arm-kernel@lists.infradead.org
Subject: mvebu: Device bus driver resurrection
Date: Fri, 5 Apr 2013 18:26:17 -0300 [thread overview]
Message-ID: <20130405212616.GB2290@localhost> (raw)
In-Reply-To: <20130326164505.GB30255@obsidianresearch.com>
Hi Jason,
On Tue, Mar 26, 2013 at 10:45:05AM -0600, Jason Gunthorpe wrote:
> On Tue, Mar 26, 2013 at 09:43:38AM -0300, Ezequiel Garcia wrote:
> > Hello everyone,
> >
> > Now that we've all agreed on a mvebu mbus driver (or a first version of it)
> > I'd like to resurrect the Device Bus driver.
> >
> > As far as I can remember, the last things said about this driver were:
> >
> > * The timing parameters should be in {nano,pico,etc} seconds,
> > instead of ticks.
>
> Yes, and I saw Rob Herring note that the DT parameters in cases like
> that should end in -ps
>
> > * Although not everyone agreed, this driver was a good thing to have
> > so we no longer depend on the bootloader setting these parameters.
>
> Please make the timing parameters mandatory, not optional. If boot
> loader set timing is going to be used then this driver should not be
> involved. Otherwise the timing should be fully specified and no values
> from the bootloader should be retained.
>
> > * The address decoding windows should *not* be setup by this driver,
> > but rather be described in the device tree itself.
>
> I'm going to suggest you send out a quick DT sample for what you are
> thinking, that might save lots of effort?
>
I've just sent a v2 for the Device Bus work, which takes care of all
your comments, except for the quick DT sample.
I hope it looks better now!
I'm not sure how close we are to an agreed mbus DTS binding, but I hope
the Device Bus can still get merged as it is, so we can have NOR support
as early as possible. Since the proposed DTS is really minimal, I expect
it to be innocuous.
If at all possible, could you take a look at it and tell me what do you think?
--
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
prev parent reply other threads:[~2013-04-05 21:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-26 12:43 mvebu: Device bus driver resurrection Ezequiel Garcia
2013-03-26 13:05 ` Thomas Petazzoni
2013-03-26 16:45 ` Jason Gunthorpe
2013-03-26 16:55 ` Thomas Petazzoni
2013-04-05 21:26 ` Ezequiel Garcia [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130405212616.GB2290@localhost \
--to=ezequiel.garcia@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).