From mboxrd@z Thu Jan 1 00:00:00 1970 From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni) Date: Mon, 8 Apr 2013 23:53:41 +0200 Subject: [PATCHv7 08/17] pci: PCIe driver for Marvell Armada 370/XP systems In-Reply-To: <201304082334.13186.arnd@arndb.de> References: <1364395234-11195-1-git-send-email-thomas.petazzoni@free-electrons.com> <20130408225741.74fc383c@skate> <201304082334.13186.arnd@arndb.de> Message-ID: <20130408235341.7012b791@skate> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Dear Arnd Bergmann, On Mon, 8 Apr 2013 23:34:12 +0200, Arnd Bergmann wrote: > > No, I'm assuming PCIBIOS_MIN_IO is always 0. So presumarly, this should > > be something like: > > > > pcie->realio.end = min(PCIBIOS_MIN_IO + > > resource_size(&pcie->io), > > IO_SPACE_LIMIT); > > > > Normally PCIBIOS_MIN_IO is 0x1000, since the first 4096 ports are reserved > for ISA and PCMCIA compatible drivers and should not be assigned to > PCI devices. So the first port should get ports 0x1000 to 0xffff, later > ones can used the entire 65536 ports e.g. 0x10000 to 0x1ffff. Then I guess it should work with the code I'm proposing here, no? Note: this pcie->realio region is global: it will be shared by all PCIe interfaces. Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com