From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] mfd: db8500-prcmu: Return early if the TCPM cannot be located
Date: Tue, 9 Apr 2013 11:29:49 +0100 [thread overview]
Message-ID: <20130409102949.GC25316@gmail.com> (raw)
In-Reply-To: <20130409100510.GP24058@zurbaran>
On Tue, 09 Apr 2013, Samuel Ortiz wrote:
> Hi Lee,
>
> On Thu, Apr 04, 2013 at 11:39:00AM +0100, Lee Jones wrote:
> > Currently we check to see if we obtained the Tightly Coupled Program
> > Memory (TCPM) base and only execute the code within the check if we
> > have it. It's more traditional to return early if we don't have it.
> > This way we can flatten most of the function's code down to a single
> > tab spacing.
> >
> > Cc: Samuel Ortiz <sameo@linux.intel.com>
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> > drivers/mfd/db8500-prcmu.c | 40 +++++++++++++++++++++-------------------
> > 1 file changed, 21 insertions(+), 19 deletions(-)
> I had to apply this one manually, please check if it was done correctly from
> my mfd-next tree.
Yes, looks good.
I think it was only 'db8500_prcmu_early_init()' and the line numbers
which confused it.
Kind regards,
Lee
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2013-04-09 10:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-04 10:39 [PATCH 1/2] mfd: db8500-prcmu: Return early if the TCPM cannot be located Lee Jones
2013-04-04 10:39 ` [PATCH 2/2] mfd: db8500-prcmu: Support platform dependant device selection Lee Jones
2013-04-09 10:06 ` Samuel Ortiz
2013-04-09 13:00 ` Samuel Ortiz
2013-04-09 11:58 ` Lee Jones
2013-04-09 19:52 ` [PATCH 2/2 v2] " Lee Jones
2013-04-09 20:55 ` Samuel Ortiz
2013-04-09 10:05 ` [PATCH 1/2] mfd: db8500-prcmu: Return early if the TCPM cannot be located Samuel Ortiz
2013-04-09 10:29 ` Lee Jones [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-04-04 9:31 Lee Jones
2013-04-04 10:05 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130409102949.GC25316@gmail.com \
--to=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).