From: jgunthorpe@obsidianresearch.com (Jason Gunthorpe)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 08/10] arm: kirkwood: convert QNAP TS219 to use DT for the PCIe interface
Date: Thu, 11 Apr 2013 10:51:58 -0600 [thread overview]
Message-ID: <20130411165158.GA5865@obsidianresearch.com> (raw)
In-Reply-To: <20130411052432.GP13524@lunn.ch>
On Thu, Apr 11, 2013 at 07:24:32AM +0200, Andrew Lunn wrote:
> I've hacked around with PCI driver on my QNAP TS119P+, which does not
> have any PCI devices, and never had any problems with the driver
> enabled and finding two empty PCI busses. PCI does not share any pins
> with anything else. So i think it is safe to just enable it for all
> devices.
In the general case, this is probably only safe if the board has
configured the PEX to have the PHY clock. Marvell has guidelines for
unused PEX's that would result in the PHY clock being permanently
inactive.
Register 10030 tells what the strap for the PHY clock is. I expect in
many cases the PEX driver should not be loaded if the PHY clock is not
internally derived. Maybe checking this register will tell your QNAPs
apart?
Jason
next prev parent reply other threads:[~2013-04-11 16:51 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-10 22:20 [PATCHv2 00/10] Use the mvebu PCIe driver on Kirkwood Thomas Petazzoni
2013-04-10 22:20 ` [PATCHv2 01/10] pci: mvebu: enable driver usage " Thomas Petazzoni
2013-04-10 22:20 ` [PATCHv2 02/10] bus: mvebu: fix mistake in PCIe window target attribute for Kirkwood Thomas Petazzoni
2013-04-11 17:14 ` Jason Cooper
2013-04-10 22:20 ` [PATCHv2 03/10] arm: kirkwood: move PCIe window init to legacy driver Thomas Petazzoni
2013-04-10 22:20 ` [PATCHv2 04/10] arm: kirkwood: add SoC-level Device Tree data for PCIe interfaces Thomas Petazzoni
2013-04-13 10:30 ` Andrew Lunn
2013-04-13 14:04 ` Thomas Petazzoni
2013-04-13 19:04 ` Jason Cooper
2013-04-10 22:20 ` [PATCHv2 05/10] arm: kirkwood: convert Iomega Iconnect to use DT for the PCIe interface Thomas Petazzoni
2013-04-10 22:20 ` [PATCHv2 06/10] arm: kirkwood: convert MPL CEC4 " Thomas Petazzoni
2013-04-10 22:20 ` [PATCHv2 07/10] arm: kirkwood: convert ZyXEL NSA310 " Thomas Petazzoni
2013-04-10 22:20 ` [PATCHv2 08/10] arm: kirkwood: convert QNAP TS219 " Thomas Petazzoni
2013-04-11 0:33 ` Jason Cooper
2013-04-11 5:24 ` Andrew Lunn
2013-04-11 16:51 ` Jason Gunthorpe [this message]
2013-04-13 9:26 ` Andrew Lunn
2013-04-13 10:40 ` Thomas Petazzoni
2013-04-11 19:45 ` Andrew Lunn
2013-04-11 19:33 ` Andrew Lunn
2013-04-13 10:36 ` Andrew Lunn
2013-04-13 11:03 ` [PATCH] " Andrew Lunn
2013-04-10 22:20 ` [PATCHv2 09/10] arm: kirkwood: convert db-88f6281 to the Device Tree Thomas Petazzoni
2013-04-10 22:20 ` [PATCHv2 10/10] arm: kirkwood: update defconfig with PCIe driver and board updates Thomas Petazzoni
2013-04-13 13:14 ` [PATCHv2 00/10] Use the mvebu PCIe driver on Kirkwood Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130411165158.GA5865@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).