From: mturquette@linaro.org (Mike Turquette)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] clk: composite: rename 'div' references to 'rate'
Date: Thu, 11 Apr 2013 10:56:56 -0700 [thread overview]
Message-ID: <20130411175656.7915.24871@quantum> (raw)
In-Reply-To: <5166A147.1050505@nvidia.com>
Quoting Prashant Gaikwad (2013-04-11 04:40:55)
> On Thursday 11 April 2013 03:32 AM, Mike Turquette wrote:
> > Rename all div_hw and div_ops related variables and functions to use
> > rate_hw, rate_ops, etc. This is to make the rate-change portion of the
> > composite clk implementation more generic. A patch following this one
> > will allow for fixed-rate clocks to reuse this infrastructure.
> >
> > Signed-off-by: Mike Turquette <mturquette@linaro.org>
> > Cc: Prashant Gaikwad <pgaikwad@nvidia.com>
> > Cc: Emilio L?pez <emilio@elopez.com.ar>
> > Cc: Gregory CLEMENT <gregory.clement@free-electrons.com>
> > ---
> > drivers/clk/clk-composite.c | 40 ++++++++++++++++++++--------------------
> > include/linux/clk-provider.h | 14 +++++++-------
> > 2 files changed, 27 insertions(+), 27 deletions(-)
> >
> <snip>
>
> >
> > if (composite->gate_hw)
> > composite->gate_hw->clk = clk;
> > diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h
> > index 9fdfae7..f5ba8c5 100644
> > --- a/include/linux/clk-provider.h
> > +++ b/include/linux/clk-provider.h
> > @@ -352,11 +352,11 @@ struct clk *clk_register_fixed_factor(struct device *dev, const char *name,
> > * struct clk_composite - aggregate clock of mux, divider and gate clocks
> > *
> > * @hw: handle between common and hardware-specific interfaces
> > - * @mux_hw: handle between composite and hardware-specifix mux clock
> > - * @div_hw: handle between composite and hardware-specifix divider clock
> > - * @gate_hw: handle between composite and hardware-specifix gate clock
> > + * @mux_hw: handle between composite and hardware-specific mux clock
> > + * @rate_hw: handle between composite and hardware-specific rateider clock
>
> Small nitpick s/rateider/rate
>
> Reviewed-by: Prashant Gaikwad <pgaikwad@nvidia.com>
>
Good catch!
Thanks,
Mike
> > + * @gate_hw: handle between composite and hardware-specific gate clock
> > * @mux_ops: clock ops for mux
> > - * @div_ops: clock ops for divider
> > + * @rate_ops: clock ops for rateider
> > * @gate_ops: clock ops for gate
> > */
> > struct clk_composite {
> > @@ -364,18 +364,18 @@ struct clk_composite {
> > struct clk_ops ops;
> >
> > struct clk_hw *mux_hw;
> > - struct clk_hw *div_hw;
> > + struct clk_hw *rate_hw;
> > struct clk_hw *gate_hw;
> >
> > const struct clk_ops *mux_ops;
> > - const struct clk_ops *div_ops;
> > + const struct clk_ops *rate_ops;
> > const struct clk_ops *gate_ops;
> > };
> >
> > struct clk *clk_register_composite(struct device *dev, const char *name,
> > const char **parent_names, int num_parents,
> > struct clk_hw *mux_hw, const struct clk_ops *mux_ops,
> > - struct clk_hw *div_hw, const struct clk_ops *div_ops,
> > + struct clk_hw *rate_hw, const struct clk_ops *rate_ops,
> > struct clk_hw *gate_hw, const struct clk_ops *gate_ops,
> > unsigned long flags);
> >
next prev parent reply other threads:[~2013-04-11 17:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-09 13:48 [PATCH 0/3] sunxi: unify main oscillator and its gate Emilio López
2013-04-09 13:48 ` [PATCH 1/3] clk: composite: Add fixed-rate support Emilio López
2013-04-09 15:41 ` Gregory CLEMENT
2013-04-09 16:04 ` Emilio López
2013-04-10 22:02 ` [PATCH 0/3] fixed-rate and fixed-factor clocks in composite clock Mike Turquette
2013-04-10 22:02 ` [PATCH 1/3] clk: composite: rename 'div' references to 'rate' Mike Turquette
2013-04-11 11:40 ` Prashant Gaikwad
2013-04-11 17:56 ` Mike Turquette [this message]
2013-04-10 22:02 ` [PATCH 2/3] clk: composite: allow fixed rates & fixed dividers Mike Turquette
2013-04-11 11:47 ` Prashant Gaikwad
2013-04-11 17:56 ` Mike Turquette
2013-04-10 22:02 ` [PATCH v2 3/3] clk: sunxi: Unify oscillator clock Mike Turquette
2013-04-11 0:07 ` Emilio López
2013-04-12 18:40 ` Mike Turquette
2013-04-11 18:31 ` [PATCH v2 1/2] clk: composite: rename 'div' references to 'rate' Mike Turquette
2013-04-11 18:31 ` [PATCH v2 2/2] clk: composite: allow fixed rates & fixed dividers Mike Turquette
2013-04-09 13:48 ` [PATCH 2/3] clk: sunxi: Unify oscillator clock Emilio López
2013-04-09 13:48 ` [PATCH 3/3] ARM: sunxi: unify osc24M_fixed and osc24M Emilio López
2013-04-15 8:45 ` Maxime Ripard
2013-04-09 14:56 ` [PATCH 0/3] sunxi: unify main oscillator and its gate Gregory CLEMENT
2013-04-09 15:04 ` Emilio López
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130411175656.7915.24871@quantum \
--to=mturquette@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).