[PATCH v2 05/11] ASoC: fsl-ssi: Add support for imx-pcm-fiq

[mpa@pengutronix.de (Markus Pargmann)]

On Sun, Apr 14, 2013 at 10:25:49AM -0500, Timur Tabi wrote:
> Markus Pargmann wrote:
> >I only ported the imx-ssi ac97 driver code and tested twice using DMA
> >without success. But there is a good description of the problem in
> >imx-ssi:
> >
> >" The WM9712 with which this driver
> >was developed with always sends GPIO status data in slot 12 which
> >we receive in our (PCM-) data stream. The only chance we have is to
> >manually skip this data in the FIQ handler."
> 
> Ah, so this is a work-around for a bug, where the codec is
> incompatible with the SoC?  Mark, are you familiar with this issue?
> Is there a way to reconfigure the codec so that it works better with
> the SoC?  It seems ridiculous to add all this code just because an
> incompatible codec was chosen for some board.
> 
> Either way, the board DTS needs to clearly state *why* we're
> enabling FIQ mode when DMA mode should work.  And the patch that
> adds FIQ support needs to say that it's for boards with broken DMA
> support.

Okay, I will add those comments to the commit message, binding
documentation and add parts of the imx-ssi problem description to
fsl-ssi.

Regards,

Markus

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |