From: cdall@cs.columbia.edu (Christoffer Dall)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: KVM: fix unbalanced get_cpu() in access_dcsw
Date: Sun, 14 Apr 2013 23:46:50 -0700 [thread overview]
Message-ID: <20130415064650.GA44752@gmail.com> (raw)
In-Reply-To: <4a199cdd4998480ed6ba3f1858698903@localhost>
On Fri, Apr 12, 2013 at 09:17:46PM +0200, Marc Zyngier wrote:
> On Fri, 12 Apr 2013 19:13:32 +0100, Will Deacon <will.deacon@arm.com>
> wrote:
> > On Fri, Apr 12, 2013 at 06:13:48PM +0100, Marc Zyngier wrote:
> >> In the very unlikely event where a guest would be foolish enough to
> >> *read* from a write-only cache maintainance register, we end up
> >> with preemption disabled, due to a misplaced get_cpu().
> >>
> >> Just move the "is_write" test outside of the critical section.
> >>
> >> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
> >
> > I found it second time around!
> >
> > Reported-by: Will Deacon <will.deacon@arm.com>
>
> Indeed you did! :-)
>
> I'll add that to the commit, and on a couple of other as well...
I applied the patch and added the tag, thanks.
-Christoffer
prev parent reply other threads:[~2013-04-15 6:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-12 17:13 [PATCH] ARM: KVM: fix unbalanced get_cpu() in access_dcsw Marc Zyngier
2013-04-12 18:13 ` Will Deacon
2013-04-12 19:17 ` Marc Zyngier
2013-04-15 6:46 ` Christoffer Dall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130415064650.GA44752@gmail.com \
--to=cdall@cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).