From: dave.martin@linaro.org (Dave Martin)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 2/2] ARM: DT: kernel: DT cpu node bindings update
Date: Tue, 16 Apr 2013 15:30:18 +0100 [thread overview]
Message-ID: <20130416143018.GB2229@linaro.org> (raw)
In-Reply-To: <516C544A.4090107@wwwdotorg.org>
On Mon, Apr 15, 2013 at 01:26:02PM -0600, Stephen Warren wrote:
> On 04/15/2013 10:13 AM, Lorenzo Pieralisi wrote:
[...]
> > + - enable-method
> > + Usage: required on ARM 64-bit systems, optional on ARM 32-bit
> > + systems
If we define no meaningful enumerations for 32-bit systems (for example,
the spin-table boot method doesn't exist), then arguably this property
should be prohibited for 32-bit systems in this version of the binding.
The binding should be extended later when we have enable methods to add?
(enable-method = "psci" is one plausible addition)
> > + Value type: <string>
> > + Definition: On ARM 64-bit systems must be "spin-table" [1].
>
> Can that be an integer instead? with dtc+cpp support, that shouldn't
> hurt the eyes too much any more.
That doesn't feel very DT-like, and it makes the standalone FDT excessively
cryptic without the headers. Does it really matter that much? DT parsing
should not be on any performance-critical path.
Mostly, DT convention seems to be to use legible string names for
enumerations like this.
Anything which tends to encrypt the DT content starts us on a slippery
slope IMHO. Converting the DT back to a vaguely human-readable form
becomes impossible without the headers.
Cheers
---Dave
next prev parent reply other threads:[~2013-04-16 14:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-15 16:13 [RFC PATCH 0/2] ARM: DT cpu bindings updates Lorenzo Pieralisi
2013-04-15 16:13 ` [RFC PATCH 1/2] ARM: DT: kernel: move temporary cpu map stack array to static data Lorenzo Pieralisi
2013-04-15 16:13 ` [RFC PATCH 2/2] ARM: DT: kernel: DT cpu node bindings update Lorenzo Pieralisi
2013-04-15 19:26 ` Stephen Warren
2013-04-16 10:45 ` Lorenzo Pieralisi
2013-04-16 15:57 ` Stephen Warren
2013-04-16 16:21 ` Benjamin Herrenschmidt
2013-04-16 14:30 ` Dave Martin [this message]
2013-04-17 9:14 ` Mark Rutland
2013-04-17 15:14 ` Stephen Warren
2013-04-17 16:02 ` Nicolas Pitre
2013-04-17 16:23 ` Stephen Warren
2013-04-17 16:36 ` Nicolas Pitre
2013-04-17 16:56 ` Dave Martin
2013-04-17 16:24 ` Benjamin Herrenschmidt
2013-04-18 12:40 ` Grant Likely
2013-04-16 2:41 ` Simon Horman
2013-04-16 11:00 ` Lorenzo Pieralisi
2013-04-17 9:35 ` Nicolas Ferre
2013-04-17 11:44 ` Lorenzo Pieralisi
2013-04-17 9:48 ` Arnd Bergmann
2013-04-17 11:02 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130416143018.GB2229@linaro.org \
--to=dave.martin@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).