From mboxrd@z Thu Jan 1 00:00:00 1970 From: grant.likely@secretlab.ca (Grant Likely) Date: Wed, 17 Apr 2013 17:00:15 +0100 Subject: [PATCH v7 1/3] of/pci: Unify pci_process_bridge_OF_ranges from Microblaze and PowerPC In-Reply-To: <20130416103005.GB12726@arm.com> References: <1366107508-12672-1-git-send-email-Andrew.Murray@arm.com> <1366107508-12672-2-git-send-email-Andrew.Murray@arm.com> <20130416103005.GB12726@arm.com> Message-ID: <20130417160015.777453E2B73@localhost> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, 16 Apr 2013 11:30:06 +0100, Andrew Murray wrote: > On Tue, Apr 16, 2013 at 11:18:26AM +0100, Andrew Murray wrote: > > The pci_process_bridge_OF_ranges function, used to parse the "ranges" > > property of a PCI host device, is found in both Microblaze and PowerPC > > architectures. These implementations are nearly identical. This patch > > moves this common code to a common place. > > > > Signed-off-by: Andrew Murray > > Signed-off-by: Liviu Dudau > > Reviewed-by: Rob Herring > > Tested-by: Thomas Petazzoni > > Tested-by: Linus Walleij > > Acked-by: Michal Simek > > --- > > arch/microblaze/include/asm/pci-bridge.h | 5 +- > > arch/microblaze/pci/pci-common.c | 192 ---------------------------- > > arch/powerpc/include/asm/pci-bridge.h | 5 +- > > arch/powerpc/kernel/pci-common.c | 192 ---------------------------- > > Is there anyone on linuxppc-dev/linux-mips that can help test this patchset? > > I've tested that it builds on powerpc with a variety of configs (some which > include fsl_pci.c implementation). Though I don't have hardware to verify that > it works. > > I haven't tested this builds or runs on MIPS. > > You shouldn't see any difference in behaviour or new warnings and PCI devices > should continue to operate as before. I've got through a line-by-line comparison between powerpc, microblaze, and then new code. The differences are purely cosmetic, so I have absolutely no concerns about this patch. I've applied it to my tree. g.