From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] serial: pl011: Add Device Tree support to request DMA channels
Date: Thu, 18 Apr 2013 09:18:12 +0100 [thread overview]
Message-ID: <20130418081811.GF14496@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1366272857-14038-1-git-send-email-lee.jones@linaro.org>
On Thu, Apr 18, 2013 at 09:14:16AM +0100, Lee Jones wrote:
> @@ -269,7 +270,10 @@ static void pl011_dma_probe_initcall(struct uart_amba_port *uap)
> dma_cap_zero(mask);
> dma_cap_set(DMA_SLAVE, mask);
>
> - chan = dma_request_channel(mask, plat->dma_filter, plat->dma_tx_param);
> + chan = dma_request_slave_channel_compat(mask,
> + (plat) ? plat->dma_filter : NULL,
> + (plat) ? plat->dma_tx_param : NULL,
> + uap->port.dev, "tx");
> if (!chan) {
> dev_err(uap->port.dev, "no TX DMA channel!\n");
> return;
This suffers the same problem with your MMCI patch. If you're using DT and
don't provide the DMA information, you get errors printed. That's not on
for an optional driver feature, especially when that feature causes
functional difficulties on various platforms and so is _purposely_ omitted.
next prev parent reply other threads:[~2013-04-18 8:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-18 8:14 [PATCH v2] serial: pl011: Add Device Tree support to request DMA channels Lee Jones
2013-04-18 8:18 ` Russell King - ARM Linux [this message]
2013-04-18 8:39 ` Lee Jones
2013-04-18 9:00 ` Russell King - ARM Linux
2013-04-20 10:33 ` Arnd Bergmann
2013-04-21 8:53 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130418081811.GF14496@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).