From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: smp: call platform's cpu_die in ipi_cpu_stop
Date: Thu, 18 Apr 2013 18:18:01 +0100 [thread overview]
Message-ID: <20130418171801.GC14496@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1365251824-4852-2-git-send-email-kevin@bracey.fi>
On Sat, Apr 06, 2013 at 03:37:04PM +0300, Kevin Bracey wrote:
> When hotplugging out, both cpu_kill and cpu_die have always been called.
> But when smp_send_stop was used in machine_shutdown or panic, only
> cpu_kill was called.
>
> This causes problems for co-ordination between cpu_kill and cpu_die, as
> attempted by shmobile. So add cpu_die call to ipi_cpu_stop, to ensure
> that cpu_kill and cpu_die calls always occur together.
Actually, I'd prefer to pull more code out of the platforms. Now
that we have flush_cache_louis(), we can flush the L1 cache for the
CPU going down in cpu_die() itself. We just need to be careful
with that complete() call to ensure that becomes visible to other
cores before power is cut to the L1 cache.
That's fine though - because it must become visible for __cpu_die()
to continue (otherwise it will time out).
That should render shmobile's cpu_dead thing unnecessary, because the
platform independent code will do the required synchronisation.
next prev parent reply other threads:[~2013-04-18 17:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-06 12:37 [PATCH] cpu_kill/cpu_die coordination Kevin Bracey
2013-04-06 12:37 ` [PATCH] ARM: smp: call platform's cpu_die in ipi_cpu_stop Kevin Bracey
2013-04-18 17:18 ` Russell King - ARM Linux [this message]
2013-04-18 18:25 ` Russell King - ARM Linux
2013-04-18 19:09 ` Russell King - ARM Linux
2013-05-01 13:06 ` Rob Herring
2013-05-02 17:55 ` Russell King - ARM Linux
2013-04-18 19:44 ` Kevin Bracey
2013-04-18 19:57 ` Russell King - ARM Linux
2013-04-22 17:03 ` Kevin Bracey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130418171801.GC14496@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).