From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] gpio/omap: ensure gpio context is initialised
Date: Fri, 19 Apr 2013 08:36:14 -0700 [thread overview]
Message-ID: <20130419153614.GF10155@atomide.com> (raw)
In-Reply-To: <51715772.9020003@ti.com>
* Santosh Shilimkar <santosh.shilimkar@ti.com> [130419 07:43]:
> On Friday 19 April 2013 07:35 PM, Kevin Hilman wrote:
> > Santosh Shilimkar <santosh.shilimkar@ti.com> writes:
> >
> >> On Friday 19 April 2013 06:19 AM, Jon Hunter wrote:
> >>>
> >>> On 04/18/2013 07:34 PM, Jon Hunter wrote:
> >>>>
> >>>> On 04/18/2013 06:10 PM, Jon Hunter wrote:
> >>>>> On 04/18/2013 04:34 PM, Kevin Hilman wrote:
> >>>>
> >>>> ...
> >>>>
> >>>>>> Why not just init context right here if bank->loses_context &&
> >>>>>> !bank->context_valid?
> >>>>
> >>>> I really like this idea a lot. It can really clean-up the code
> >>>> and really make it much more readable. Before we were playing
> >>>> some tricks with when we init'ed the get_context_loss_count()
> >>>> function pointer. How about the below?
> >>>>
> >>>> Tony, care to re-test?
Still works thanks:
Tested-by: Tony Lindgren <tony@atomide.com>
> > Assuming this driver could become a module someday (not terribly likely,
> > I know), but context_valid would have meaning for each module reload.
> >
> I don't think GPIO can ever be a module(at least on OMAP) considering the way
> it is used in many SOCs and hence the objection on that flag. GPIO is really
> an infrastructure driver which is needed to be always available for the
> client drivers to work.
Not really related to this fix.. But when booting with initramfs, we should
be able to make everything into loadable modules except things that are related
to enabling timers and interrupts. This is important for distros to be able
do generic kernels. Surely for mounting non-initramfs root GPIO is most
likely needed though :)
Regards,
Tony
next prev parent reply other threads:[~2013-04-19 15:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-17 20:31 [PATCH] gpio/omap: ensure gpio context is initialised Jon Hunter
2013-04-18 8:22 ` Santosh Shilimkar
2013-04-18 16:46 ` Jon Hunter
2013-04-18 21:34 ` Kevin Hilman
2013-04-18 23:10 ` Jon Hunter
2013-04-19 0:34 ` Jon Hunter
2013-04-19 0:49 ` Jon Hunter
2013-04-19 6:32 ` Santosh Shilimkar
2013-04-19 14:05 ` Kevin Hilman
2013-04-19 14:40 ` Santosh Shilimkar
2013-04-19 15:36 ` Tony Lindgren [this message]
2013-04-26 7:54 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130419153614.GF10155@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).