From mboxrd@z Thu Jan 1 00:00:00 1970 From: vinod.koul@intel.com (Vinod Koul) Date: Mon, 22 Apr 2013 15:40:29 +0530 Subject: [PATCH 08/32] dmaengine: ste_dma40: Optimise local MAX() macro In-Reply-To: <1366279934-30761-9-git-send-email-lee.jones@linaro.org> References: <1366279934-30761-1-git-send-email-lee.jones@linaro.org> <1366279934-30761-9-git-send-email-lee.jones@linaro.org> Message-ID: <20130422101029.GP24632@intel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Apr 18, 2013 at 11:11:50AM +0100, Lee Jones wrote: > The current implementation of the DMA40's local MAX() macro evaluates > its arguments more times than is necessary. This patch strips it > optimises it to only evaluate what's appropriate. > > Cc: Vinod Koul > Cc: Dan Williams > Cc: Per Forlin > Cc: Rabin Vincent > Reported-by: Harvey Harrison > Signed-off-by: Lee Jones > --- > drivers/dma/ste_dma40.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c > index b21a8a3..7b451b2 100644 > --- a/drivers/dma/ste_dma40.c > +++ b/drivers/dma/ste_dma40.c > @@ -53,7 +53,7 @@ > #define D40_ALLOC_PHY BIT(30) > #define D40_ALLOC_LOG_FREE BIT(0) > > -#define MAX(a, b) (((a) < (b)) ? (b) : (a)) > +#define MAX(a, b) ((a > b) ? a : b) Am not a big fan of own redefines, can you use kernel max() macro instead -- ~Vinod > > #define D40_IS_SRC(dir) ((dir == STEDMA40_PERIPH_TO_MEM) ? true : false) > #define D40_IS_DST(dir) (((dir == STEDMA40_MEM_TO_PERIPH) || \ > -- > 1.7.10.4 >