From: dave.martin@linaro.org (Dave Martin)
To: linux-arm-kernel@lists.infradead.org
Subject: Latest build results - errors/warnings - lots of them
Date: Tue, 30 Apr 2013 18:28:50 +0100 [thread overview]
Message-ID: <20130430172816.GA31101@linaro.org> (raw)
In-Reply-To: <alpine.LFD.2.03.1304301110030.17372@syhkavp.arg>
On Tue, Apr 30, 2013 at 11:12:12AM -0400, Nicolas Pitre wrote:
> On Tue, 30 Apr 2013, Dave Martin wrote:
>
> > On Tue, Apr 30, 2013 at 01:04:20PM +0200, Arnd Bergmann wrote:
> > > On Tuesday 30 April 2013, Russell King - ARM Linux wrote:
> > > > Latest nightly build of 3.9+my for-next+arm-soc's for-next results in a
> > > > great load of new warnings and errors. arch/arm/common/mcpm_head.S,
> > > > arch/arm/common/mcpm_platsmp.c, arch/arm/common/vlock.S are the biggest
> > > > source of errors.
> >
> > [...]
> >
> > > >arch/arm/common/mcpm_head.S:39: Error: selected processor does not support ARM mode `ubfx r9,r0,#0,#8'
> > > >arch/arm/common/mcpm_head.S:40: Error: selected processor does not support ARM mode `ubfx r10,r0,#8,#8'
> > > >arch/arm/common/mcpm_head.S:100: Error: selected processor does not support ARM mode `dmb'
> > > >arch/arm/common/mcpm_head.S:115: Error: selected processor does not support ARM mode `dmb'
> > > >arch/arm/common/mcpm_head.S:127: Error: selected processor does not support ARM mode `dmb'
> > > >arch/arm/common/mcpm_head.S:131: Error: selected processor does not support ARM mode `dmb'
> > > >arch/arm/common/mcpm_head.S:138: Error: selected processor does not support ARM mode `dsb'
> > > >arch/arm/common/mcpm_head.S:152: Error: selected processor does not support ARM mode `dmb'
> > > >arch/arm/common/mcpm_head.S:161: Error: selected processor does not support ARM mode `dmb'
> > > >arch/arm/common/mcpm_head.S:175: Error: selected processor does not support ARM mode `dmb'
> > > >arch/arm/common/vlock.S:62: Error: selected processor does not support ARM mode `dmb'
> > > >arch/arm/common/vlock.S:72: Error: selected processor does not support ARM mode `dmb'
> > > >arch/arm/common/vlock.S:72: Error: selected processor does not support ARM mode `dsb'
> > > >arch/arm/common/vlock.S:89: Error: selected processor does not support ARM mode `dmb'
> > > >arch/arm/common/vlock.S:95: Error: selected processor does not support ARM mode `dmb'
> > > >arch/arm/common/vlock.S:95: Error: selected processor does not support ARM mode `dsb'
> > > >arch/arm/common/vlock.S:102: Error: selected processor does not support ARM mode `dmb'
> > > >arch/arm/common/vlock.S:105: Error: selected processor does not support ARM mode `dsb'
> > >
> > > Right, the problem here is that the code was never tested with an ARMv6+ARMv7 config.
> > > We can either fix it up by adding
> > >
> > > .arch armv7-a
> > >
> > > in the assembly files, or by doing the same in the Makefile:
> > >
> > > AFLAGS_vlock.S += -march=armv7-a
> > > AFLAGS_mcpm_head.S += -march=armv7-a
> >
> >
> > Hmmm, this code was tested with ARCH_MULTIPLATFORM, but it looks like
> > no v6 boards were configured in when testing that...
> >
> >
> > Assuming people are OK with the Makefile route, here's a patch for that,
> > build-tested with a v6+v7 ARCH_MULTIPLATFORM config.
>
> Isn't the .arch armv7-a route a bit cleaner? That would have been my
> choice, although I don't feel strongly about it.
I don't feel strongly either. We already have the CFLAGS_DISABLE stuff,
so it didn't feel that unnatural to add this in the Makefile; but .arch
would work equally well.
If somebody wants to change it, it's not a problem for me, but I didn't
want to create extra disruption by proposing a different patch...
Cheers
---Dave
next prev parent reply other threads:[~2013-04-30 17:28 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-30 8:17 Latest build results - errors/warnings - lots of them Russell King - ARM Linux
2013-04-30 11:04 ` Arnd Bergmann
2013-04-30 11:43 ` Dave Martin
2013-04-30 11:54 ` Arnd Bergmann
2013-04-30 15:12 ` Nicolas Pitre
2013-04-30 17:28 ` Dave Martin [this message]
2013-04-30 18:18 ` Nicolas Pitre
2013-05-02 8:34 ` Russell King - ARM Linux
2013-05-02 9:46 ` Russell King - ARM Linux
2013-05-02 10:40 ` Dave Martin
2013-04-30 16:11 ` Tony Lindgren
2013-04-30 21:49 ` Tony Lindgren
2013-05-02 6:02 ` Shawn Guo
2013-04-30 23:11 ` Arnd Bergmann
2013-04-30 23:51 ` Tony Lindgren
2013-05-01 0:22 ` Tony Lindgren
2013-05-02 8:22 ` Russell King - ARM Linux
2013-05-02 15:38 ` Tony Lindgren
2013-05-02 17:07 ` Eduardo Valentin
2013-05-02 18:03 ` Arnd Bergmann
2013-05-02 18:45 ` Eduardo Valentin
2013-05-02 18:06 ` Felipe Balbi
2013-05-02 18:46 ` Eduardo Valentin
2013-05-02 18:54 ` Russell King - ARM Linux
2013-05-06 2:40 ` NeilBrown
2013-05-08 22:17 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130430172816.GA31101@linaro.org \
--to=dave.martin@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).