linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] ARM: highbank: fix build after cache flush change
Date: Thu, 2 May 2013 20:41:26 +0100	[thread overview]
Message-ID: <20130502194125.GH14496@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <5182C0DF.9000500@gmail.com>

On Thu, May 02, 2013 at 02:39:11PM -0500, Rob Herring wrote:
> On 05/02/2013 12:23 PM, Arnd Bergmann wrote:
> > Commit "ARM: cpu hotplug: remove majority of cache flushing from
> > platforms" has removed the inclusion of asm/cacheflush.h from
> > a number of files. Highbank still needs it because it calls
> > flush_cache_louis().
> 
> AFAICT, the commit in question only showed up buried in a reply to
> another thread and was never cc'ed to the relevant platform maintainers...
> 
> > 
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Cc: Russell King <rmk+kernel@arm.linux.org.uk>
> > Cc: Rob Herring <rob.herring@calxeda.com>
> > ---
> 
> I'd rather see the highbank changes dropped as this will all go away
> with PSCI in 3.11, but:
> 
> Acked-by: Rob Herring <rob.herring@calxeda.com>

I'll drop the removal of asm/cacheflush.h but not the rest of it; I
believe your existing code to be in error with or without my changes.

  reply	other threads:[~2013-05-02 19:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-02 17:23 [PATCH 0/4] ARM architecture fixes Arnd Bergmann
2013-05-02 17:23 ` [PATCH 1/4] ARM: compressed/head.S: work around new binutils warning Arnd Bergmann
2013-05-02 17:23 ` [PATCH 2/4] ARM: fix prototypes for arch_ioremap_caller functions Arnd Bergmann
2013-05-02 17:23 ` [PATCH 3/4] ARM: fix NOMMU __arm_ioremap prototype Arnd Bergmann
2013-05-02 18:20   ` Russell King - ARM Linux
2013-05-02 17:23 ` [PATCH 4/4] ARM: highbank: fix build after cache flush change Arnd Bergmann
2013-05-02 19:39   ` Rob Herring
2013-05-02 19:41     ` Russell King - ARM Linux [this message]
2013-05-02 19:44       ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130502194125.GH14496@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).