* [PATCH] ARM: kirkwood: add button for OpenBlock A6
@ 2013-05-02 19:43 Gregory CLEMENT
2013-05-02 19:53 ` Ezequiel Garcia
2013-05-02 19:57 ` Gregory CLEMENT
0 siblings, 2 replies; 4+ messages in thread
From: Gregory CLEMENT @ 2013-05-02 19:43 UTC (permalink / raw)
To: linux-arm-kernel
The OpenBlocks A6 board has one software-controlled button on the
front side, labeled "INIT", so we add minimal support for this button
in the kernel.
Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
---
arch/arm/boot/dts/kirkwood-openblocks_a6.dts | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/arm/boot/dts/kirkwood-openblocks_a6.dts b/arch/arm/boot/dts/kirkwood-openblocks_a6.dts
index d27f724..627d8d0 100644
--- a/arch/arm/boot/dts/kirkwood-openblocks_a6.dts
+++ b/arch/arm/boot/dts/kirkwood-openblocks_a6.dts
@@ -209,4 +209,17 @@
gpios = <&gpio1 11 1>;
};
};
+
+ gpio_keys {
+ compatible = "gpio-keys";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ button at 1 {
+ label = "Init Button";
+ linux,code = <116>;
+ gpios = <&gpio1 6 0>;
+ };
+ };
+
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] ARM: kirkwood: add button for OpenBlock A6
2013-05-02 19:43 [PATCH] ARM: kirkwood: add button for OpenBlock A6 Gregory CLEMENT
@ 2013-05-02 19:53 ` Ezequiel Garcia
2013-05-02 19:57 ` Gregory CLEMENT
1 sibling, 0 replies; 4+ messages in thread
From: Ezequiel Garcia @ 2013-05-02 19:53 UTC (permalink / raw)
To: linux-arm-kernel
Hi Gregory,
On Thu, May 02, 2013 at 09:43:22PM +0200, Gregory CLEMENT wrote:
> The OpenBlocks A6 board has one software-controlled button on the
> front side, labeled "INIT", so we add minimal support for this button
> in the kernel.
>
> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
> ---
> arch/arm/boot/dts/kirkwood-openblocks_a6.dts | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm/boot/dts/kirkwood-openblocks_a6.dts b/arch/arm/boot/dts/kirkwood-openblocks_a6.dts
> index d27f724..627d8d0 100644
> --- a/arch/arm/boot/dts/kirkwood-openblocks_a6.dts
> +++ b/arch/arm/boot/dts/kirkwood-openblocks_a6.dts
> @@ -209,4 +209,17 @@
> gpios = <&gpio1 11 1>;
> };
> };
> +
> + gpio_keys {
> + compatible = "gpio-keys";
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + button at 1 {
> + label = "Init Button";
> + linux,code = <116>;
> + gpios = <&gpio1 6 0>;
> + };
> + };
> +
> };
Shouldn't you add a proper pinctrl entry for this as well?
--
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] ARM: kirkwood: add button for OpenBlock A6
2013-05-02 19:43 [PATCH] ARM: kirkwood: add button for OpenBlock A6 Gregory CLEMENT
2013-05-02 19:53 ` Ezequiel Garcia
@ 2013-05-02 19:57 ` Gregory CLEMENT
2013-05-02 21:45 ` Thomas Petazzoni
1 sibling, 1 reply; 4+ messages in thread
From: Gregory CLEMENT @ 2013-05-02 19:57 UTC (permalink / raw)
To: linux-arm-kernel
On 05/02/2013 09:43 PM, Gregory CLEMENT wrote:
> The OpenBlocks A6 board has one software-controlled button on the
> front side, labeled "INIT", so we add minimal support for this button
> in the kernel.
>
Oh, I found that Thomas have already submitted the same patch but I was
misleaded because I didn't find anything related to this in v3.9,
nor in next-20130502.
You can drop this patch of course, but waht happens to Thomas' patch?
> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
> ---
> arch/arm/boot/dts/kirkwood-openblocks_a6.dts | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm/boot/dts/kirkwood-openblocks_a6.dts b/arch/arm/boot/dts/kirkwood-openblocks_a6.dts
> index d27f724..627d8d0 100644
> --- a/arch/arm/boot/dts/kirkwood-openblocks_a6.dts
> +++ b/arch/arm/boot/dts/kirkwood-openblocks_a6.dts
> @@ -209,4 +209,17 @@
> gpios = <&gpio1 11 1>;
> };
> };
> +
> + gpio_keys {
> + compatible = "gpio-keys";
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + button at 1 {
> + label = "Init Button";
> + linux,code = <116>;
> + gpios = <&gpio1 6 0>;
> + };
> + };
> +
> };
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] ARM: kirkwood: add button for OpenBlock A6
2013-05-02 19:57 ` Gregory CLEMENT
@ 2013-05-02 21:45 ` Thomas Petazzoni
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2013-05-02 21:45 UTC (permalink / raw)
To: linux-arm-kernel
Dear Gregory CLEMENT,
On Thu, 02 May 2013 21:57:06 +0200, Gregory CLEMENT wrote:
> Oh, I found that Thomas have already submitted the same patch but I
> was misleaded because I didn't find anything related to this in v3.9,
> nor in next-20130502.
>
> You can drop this patch of course, but waht happens to Thomas' patch?
I have to rework it as part as a refactoring of the pinctrl definitions
on kirkwood. I'll try to work on that soon.
Thanks,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-05-02 21:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-02 19:43 [PATCH] ARM: kirkwood: add button for OpenBlock A6 Gregory CLEMENT
2013-05-02 19:53 ` Ezequiel Garcia
2013-05-02 19:57 ` Gregory CLEMENT
2013-05-02 21:45 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).