From: balbi@ti.com (Felipe Balbi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP-USB: Fix possible memory leak
Date: Fri, 3 May 2013 09:25:06 +0300 [thread overview]
Message-ID: <20130503062506.GC27451@arwen.pp.htv.fi> (raw)
In-Reply-To: <20130503061931.GB27451@arwen.pp.htv.fi>
Hi,
On Fri, May 03, 2013 at 09:21:51AM +0300, Felipe Balbi wrote:
> > This is exactly why we have platform_device_alloc(),
> > platform_device_register_full() and friends - so that people don't have to
> > fsck around with kzalloc themselves and get it wrong like the above does.
> >
> > Would you like me to pass your details to gregkh for another one of his
> > public humilation exercises over basic kernel programming stuff? :)
>
> How about we pass yours for not reading the patch before flaming ? Note
> that $SUBJECT is *not* touching at all that line which kzallocs a
> platform_device. Wrong as it is, it's not part of $SUBJECT.
that line was added by Roger on commit
5ecd52e563f1e14f9cfe06130fbf9fdb73f227e8 (ARM: OMAP2+: omap-usb-host: Add
usbhs_init_phys()).
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130503/4a947d27/attachment.sig>
next prev parent reply other threads:[~2013-05-03 6:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-02 16:03 [PATCH] ARM: OMAP-USB: Fix possible memory leak Alexander Shiyan
2013-05-02 16:24 ` Nishanth Menon
2013-05-02 16:28 ` Re[2]: " Alexander Shiyan
2013-05-02 16:40 ` Felipe Balbi
2013-05-02 23:13 ` Russell King - ARM Linux
2013-05-03 6:21 ` Felipe Balbi
2013-05-03 6:25 ` Felipe Balbi [this message]
2013-05-03 6:25 ` Felipe Balbi
2013-05-03 8:15 ` Russell King - ARM Linux
2013-05-03 8:30 ` Felipe Balbi
2013-05-03 8:33 ` Russell King - ARM Linux
2013-05-03 8:32 ` Russell King - ARM Linux
2013-05-03 8:39 ` Felipe Balbi
2013-05-03 8:43 ` Russell King - ARM Linux
2013-05-02 19:52 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130503062506.GC27451@arwen.pp.htv.fi \
--to=balbi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox