linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4 v2] mfd: ab8500-gpadc: Suppress 'ignoring regulator_enable() return value' warning
Date: Fri, 3 May 2013 12:15:37 +0100	[thread overview]
Message-ID: <20130503111537.GH24153@gmail.com> (raw)
In-Reply-To: <1367509690-24022-3-git-send-email-lee.jones@linaro.org>

drivers/mfd/ab8500-gpadc.c: In function ?ab8500_gpadc_resume?:
drivers/mfd/ab8500-gpadc.c:911:18: warning: ignoring return value of
        ?regulator_enable?, declared with attribute warn_unused_result
        [-Wunused-result]

Cc: Samuel Ortiz <sameo@linux.intel.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>

diff --git a/drivers/mfd/ab8500-gpadc.c b/drivers/mfd/ab8500-gpadc.c
index 5e65b28..13f7866 100644
--- a/drivers/mfd/ab8500-gpadc.c
+++ b/drivers/mfd/ab8500-gpadc.c
@@ -907,14 +907,17 @@ static int ab8500_gpadc_suspend(struct device *dev)
 static int ab8500_gpadc_resume(struct device *dev)
 {
 	struct ab8500_gpadc *gpadc = dev_get_drvdata(dev);
+	int ret;
 
-	regulator_enable(gpadc->regu);
+	ret = regulator_enable(gpadc->regu);
+	if (ret)
+		dev_err(dev, "Failed to enable vtvout LDO: %d\n", ret);
 
 	pm_runtime_mark_last_busy(gpadc->dev);
 	pm_runtime_put_autosuspend(gpadc->dev);
 
 	mutex_unlock(&gpadc->ab8500_gpadc_lock);
-	return 0;
+	return ret;
 }
 
 static int ab8500_gpadc_probe(struct platform_device *pdev)

  parent reply	other threads:[~2013-05-03 11:15 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-02 15:48 [PATCH 0/4] Fixing boot warnings in -next Lee Jones
2013-05-02 15:48 ` [PATCH 1/4] ARM: ux500: Rid ignored return value of regulator_enable() compiler warning Lee Jones
2013-05-03  8:27   ` Linus Walleij
2013-05-02 15:48 ` [PATCH 2/4] mfd: ab8500-gpadc: Suppress 'ignoring regulator_enable() return value' warning Lee Jones
2013-05-03  8:28   ` Linus Walleij
2013-05-03 11:04     ` Lee Jones
2013-05-03 11:22       ` Lee Jones
2013-05-03 11:15   ` Lee Jones [this message]
2013-05-03 13:41     ` [PATCH 2/4 v2] " Linus Walleij
2013-05-03 13:55       ` Lee Jones
2013-05-02 15:48 ` [PATCH 3/4] mmc: mmci: Ensure return value of regulator_enable() is checked Lee Jones
2013-05-03  8:01   ` Ulf Hansson
2013-05-03  8:16     ` Lee Jones
2013-05-03  8:20       ` Ulf Hansson
2013-05-03 10:38         ` Lee Jones
2013-05-02 15:48 ` [PATCH 4/4] staging: ste_rmi4: Suppress 'ignoring return value of ‘regulator_enable()' warning Lee Jones
2013-05-03  7:07   ` Srinidhi Kasagar
2013-05-03  7:11     ` Lee Jones
2013-05-05 14:18     ` Dan Carpenter
2013-05-06  6:51       ` Srinidhi Kasagar
2013-05-06  7:43         ` Dan Carpenter
2013-05-03 14:21   ` [PATCH 4/4 v2] " Lee Jones
2013-05-14 10:46   ` [PATCH 4/4] " Lee Jones
2013-05-14 11:05     ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130503111537.GH24153@gmail.com \
    --to=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).