From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4 v2] staging: ste_rmi4: Suppress 'ignoring return value of ‘regulator_enable()' warning
Date: Fri, 3 May 2013 15:21:46 +0100 [thread overview]
Message-ID: <20130503142146.GO24153@gmail.com> (raw)
In-Reply-To: <1367509690-24022-5-git-send-email-lee.jones@linaro.org>
drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c:
In function ?synaptics_rmi4_resume?:
drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c:1090:18:
warning: ignoring return value of ?regulator_enable?, declared
with attribute warn_unused_result [-Wunused-result
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: devel at driverdev.osuosl.org
Acked-by: Srinidhi Kasagar <srinidhi.kasagar@stericsson.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
diff --git a/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c b/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c
index fe667dd..386362c 100644
--- a/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c
+++ b/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c
@@ -1087,7 +1087,11 @@ static int synaptics_rmi4_resume(struct device *dev)
unsigned char intr_status;
struct synaptics_rmi4_data *rmi4_data = dev_get_drvdata(dev);
- regulator_enable(rmi4_data->regulator);
+ retval = regulator_enable(rmi4_data->regulator);
+ if (retval) {
+ dev_err(dev, "Regulator enable failed (%d)\n", retval);
+ return retval;
+ }
enable_irq(rmi4_data->i2c_client->irq);
rmi4_data->touch_stopped = false;
next prev parent reply other threads:[~2013-05-03 14:21 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-02 15:48 [PATCH 0/4] Fixing boot warnings in -next Lee Jones
2013-05-02 15:48 ` [PATCH 1/4] ARM: ux500: Rid ignored return value of regulator_enable() compiler warning Lee Jones
2013-05-03 8:27 ` Linus Walleij
2013-05-02 15:48 ` [PATCH 2/4] mfd: ab8500-gpadc: Suppress 'ignoring regulator_enable() return value' warning Lee Jones
2013-05-03 8:28 ` Linus Walleij
2013-05-03 11:04 ` Lee Jones
2013-05-03 11:22 ` Lee Jones
2013-05-03 11:15 ` [PATCH 2/4 v2] " Lee Jones
2013-05-03 13:41 ` Linus Walleij
2013-05-03 13:55 ` Lee Jones
2013-05-02 15:48 ` [PATCH 3/4] mmc: mmci: Ensure return value of regulator_enable() is checked Lee Jones
2013-05-03 8:01 ` Ulf Hansson
2013-05-03 8:16 ` Lee Jones
2013-05-03 8:20 ` Ulf Hansson
2013-05-03 10:38 ` Lee Jones
2013-05-02 15:48 ` [PATCH 4/4] staging: ste_rmi4: Suppress 'ignoring return value of ‘regulator_enable()' warning Lee Jones
2013-05-03 7:07 ` Srinidhi Kasagar
2013-05-03 7:11 ` Lee Jones
2013-05-05 14:18 ` Dan Carpenter
2013-05-06 6:51 ` Srinidhi Kasagar
2013-05-06 7:43 ` Dan Carpenter
2013-05-03 14:21 ` Lee Jones [this message]
2013-05-14 10:46 ` Lee Jones
2013-05-14 11:05 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130503142146.GO24153@gmail.com \
--to=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).