From: dan.carpenter@oracle.com (Dan Carpenter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] staging: ste_rmi4: Suppress 'ignoring return value of ‘regulator_enable()' warning
Date: Mon, 6 May 2013 10:43:23 +0300 [thread overview]
Message-ID: <20130506074323.GH4635@mwanda> (raw)
In-Reply-To: <20130506065138.GA31763@bnru10>
On Mon, May 06, 2013 at 12:21:39PM +0530, Srinidhi Kasagar wrote:
> > > > - regulator_enable(rmi4_data->regulator);
> > > > + retval = regulator_enable(rmi4_data->regulator);
> > > > + if (retval < 0)
> > > > + return retval;
> > > Does it make sense to add a dev_err?
> > >
> >
> > Is that a question?
> >
> > regulator_enable() already prints some warnings. Probably it's not
> > going to fail and adding code that is duplicative or will never be
> > run is pointless.
>
> It has become a habit checking the return value and spit some errors.
> And BTW, there are many drivers which does this way..Anyway if your
> intention is to avoid them for the new drivers..I dont mind skipping
> this..
It's not like I'm trying to ban error messages. There isn't any
official policy on error messages.
regards,
dan carpenter
next prev parent reply other threads:[~2013-05-06 7:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-02 15:48 [PATCH 0/4] Fixing boot warnings in -next Lee Jones
2013-05-02 15:48 ` [PATCH 1/4] ARM: ux500: Rid ignored return value of regulator_enable() compiler warning Lee Jones
2013-05-03 8:27 ` Linus Walleij
2013-05-02 15:48 ` [PATCH 2/4] mfd: ab8500-gpadc: Suppress 'ignoring regulator_enable() return value' warning Lee Jones
2013-05-03 8:28 ` Linus Walleij
2013-05-03 11:04 ` Lee Jones
2013-05-03 11:22 ` Lee Jones
2013-05-03 11:15 ` [PATCH 2/4 v2] " Lee Jones
2013-05-03 13:41 ` Linus Walleij
2013-05-03 13:55 ` Lee Jones
2013-05-02 15:48 ` [PATCH 3/4] mmc: mmci: Ensure return value of regulator_enable() is checked Lee Jones
2013-05-03 8:01 ` Ulf Hansson
2013-05-03 8:16 ` Lee Jones
2013-05-03 8:20 ` Ulf Hansson
2013-05-03 10:38 ` Lee Jones
2013-05-02 15:48 ` [PATCH 4/4] staging: ste_rmi4: Suppress 'ignoring return value of ‘regulator_enable()' warning Lee Jones
2013-05-03 7:07 ` Srinidhi Kasagar
2013-05-03 7:11 ` Lee Jones
2013-05-05 14:18 ` Dan Carpenter
2013-05-06 6:51 ` Srinidhi Kasagar
2013-05-06 7:43 ` Dan Carpenter [this message]
2013-05-03 14:21 ` [PATCH 4/4 v2] " Lee Jones
2013-05-14 10:46 ` [PATCH 4/4] " Lee Jones
2013-05-14 11:05 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130506074323.GH4635@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).