From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: imx: compile fix for hotplug.c
Date: Wed, 8 May 2013 09:48:10 +0200 [thread overview]
Message-ID: <20130508074810.GN23285@pengutronix.de> (raw)
In-Reply-To: <1367474331-3479-1-git-send-email-shawn.guo@linaro.org>
Hello Shawn,
On Thu, May 02, 2013 at 01:58:51PM +0800, Shawn Guo wrote:
> Commit bca7a5a (ARM: cpu hotplug: remove majority of cache flushing
> from platforms) removes include of <asm/cacheflush.h> and hence
> discovers a few indirect inclusion and declaration problems as below.
>
> CC arch/arm/mach-imx/hotplug.o
> In file included from arch/arm/mach-imx/hotplug.c:16:0:
> arch/arm/mach-imx/common.h:100:29: warning: ?struct pt_regs? declared inside parameter list [enabled by default]
> arch/arm/mach-imx/common.h:100:29: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
> arch/arm/mach-imx/common.h:101:29: warning: ?struct pt_regs? declared inside parameter list [enabled by default]
> arch/arm/mach-imx/hotplug.c: In function ?imx_cpu_die?:
> arch/arm/mach-imx/hotplug.c:53:2: error: implicit declaration of function ?cpu_do_idle? [-Werror=implicit-function-declaration]
> arch/arm/mach-imx/hotplug.c: In function ?imx_cpu_kill?:
> arch/arm/mach-imx/hotplug.c:58:26: error: ?jiffies? undeclared (first use in this function)
> arch/arm/mach-imx/hotplug.c:58:26: note: each undeclared identifier is reported only once for each function it appears in
> arch/arm/mach-imx/hotplug.c:58:2: error: implicit declaration of function ?msecs_to_jiffies? [-Werror=implicit-function-declaration]
> arch/arm/mach-imx/hotplug.c:61:3: error: implicit declaration of function ?time_after? [-Werror=implicit-function-declaration]
>
> Fix them by adding the needed inclusion and declaration.
>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
I just sent an equivalent patch for that issue (so:
Acked-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
).
Is this patch already queued somewhere?
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2013-05-08 7:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-02 5:58 [PATCH] ARM: imx: compile fix for hotplug.c Shawn Guo
2013-05-02 15:27 ` Arnd Bergmann
2013-05-08 7:48 ` Uwe Kleine-König [this message]
2013-05-08 13:25 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130508074810.GN23285@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).