From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2] net: smsc911x: don't artificially limit build
Date: Thu, 9 May 2013 11:26:50 +0100 [thread overview]
Message-ID: <20130509102650.GC8258@e106331-lin.cambridge.arm.com> (raw)
In-Reply-To: <1368095027-8448-1-git-send-email-mark.rutland@arm.com>
This should of course be PATCH, not PATCHv2.
I blame my shell's command history completion.
Mark.
On Thu, May 09, 2013 at 11:23:47AM +0100, Mark Rutland wrote:
> Currently the SMSC911X driver may only be built for a specific set of
> architectures, being limited to do so by a Kconfig depends line. This
> means that if a platform wishes to use the driver, its architecture must
> be added to the list explicitly, introducing pointless churn.
>
> This may have been due to the driver's use of the {read,write}s{b,w,l}
> functions, which have since been replaced with the more standard
> io{read,write}{8,16,32}_rep. We can instead depend on HAS_IOMEM, which
> should prevent build issues while allowing the driver to be built for
> currently unlisted architectures, including x86 and arm64.
>
> This patch removes the explicit list of architectures from the driver's
> depend line, and replaces it with a dependency on HAS_IOMEM.
>
> Signed-off-by: Mark Rutland <mark.rutland@arm.com>
> Cc: David S. Miller <davem@davemloft.net>
> Cc: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/net/ethernet/smsc/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/smsc/Kconfig b/drivers/net/ethernet/smsc/Kconfig
> index bb4c167..ff9e994 100644
> --- a/drivers/net/ethernet/smsc/Kconfig
> +++ b/drivers/net/ethernet/smsc/Kconfig
> @@ -97,7 +97,7 @@ config SMC911X
>
> config SMSC911X
> tristate "SMSC LAN911x/LAN921x families embedded ethernet support"
> - depends on (ARM || SUPERH || BLACKFIN || MIPS || MN10300)
> + depends on HAS_IOMEM
> select CRC32
> select NET_CORE
> select MII
> --
> 1.8.1.1
>
next prev parent reply other threads:[~2013-05-09 10:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-09 10:23 [PATCHv2] net: smsc911x: don't artificially limit build Mark Rutland
2013-05-09 10:26 ` Mark Rutland [this message]
2013-05-09 21:04 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130509102650.GC8258@e106331-lin.cambridge.arm.com \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox