From: mingo@kernel.org (Ingo Molnar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH -v8 00/11] Shutdown from reboot_cpuid without stopping other cpus.
Date: Fri, 10 May 2013 09:06:16 +0200 [thread overview]
Message-ID: <20130510070616.GA5763@gmail.com> (raw)
In-Reply-To: <1368127405-112717-1-git-send-email-holt@sgi.com>
* Robin Holt <holt@sgi.com> wrote:
> We recently noticed that reboot of a 1024 cpu machine takes approx 16
> minutes of just stopping the cpus. The slowdown was tracked to commit
> f96972f.
>
> The current implementation does all the work of hot removing the cpus
> before halting the system. We are switching to just migrating to the
> reboot_cpu and then continuing with shutdown/reboot.
>
> The patch set is broken into eleven parts. The first two are planned for
> the stable release. The others move the halt/shutdown/reboot related
> functions to their own kernel/reboot.c file and then move the handling
> of the kernel reboot= kernel parameter to generic kernel code.
>
>
> Changes since -v8
> - Changes reboot_cpu on stack to cpu to fix bug noticed by Russell King.
>
> - Switched unicore32 and arm from using REBOOT_WARM/COLD to HARD/SOFT.
>
> - Fixed case statement bug.
>
> - Went to using simple_strtoul for parsing reboot_cpu=smp###.
>
> - Made parsing of reboot= not use any #ifdef'd code.
>
> Changes since -v7.
> - Fixed authorship for first patch.
>
> - Rebased to Linus' current tree (51a26ae7a).
>
> Changes since -v6.
> - Cross compiled all arm architectures (using v3.9 kernel. Fails with
> current).
>
> - Added a #define for non-hotplug case.
>
> - Add #define for PF_THREAD_BOUND as compatibility to make stable easier.
>
> - Fixup s/reboot_cpu_id/reboot_cpu/
>
> - Add include of linux/uaccess.h to allow building on arm.
>
> - Removed last remaining checkpatch.pl line length warning on
> kernel/reboot.c.
>
> - Fixed the duplicate handling or the reboot= kernel parameter.
>
> Changes since -v5.
> - Moved the arch/x86 reboot= up to the generic kernel code.
>
> Changes since -v4.
> - Integrated Srivatsa S. Bhat creating cpu_hotplug_disable()
> function
>
> - Integrated comments by Srivatsa S. Bhat.
>
> - Made one more comment consistent with others in function.
>
> Changes since -v3.
> - Added a tested-by for the original reporter.
>
> - Fix compile failure found by Joe Perches.
>
> - Integrated comments by Joe Perches.
>
>
> To: Andrew Morton <akpm@linux-foundation.org>
> Cc: H. Peter Anvin <hpa@zytor.com>
> Cc: Russ Anderson <rja@sgi.com>
> Cc: Robin Holt <holt@sgi.com>
> Cc: Russell King <linux@arm.linux.org.uk>
> Cc: Guan Xuetao <gxt@mprc.pku.edu.cn>
> Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
> Cc: the arch/x86 maintainers <x86@kernel.org>
> Cc: Arm Mailing List <linux-arm-kernel@lists.infradead.org>
Looks nice now to me. For the x86 bits:
Acked-by: Ingo Molnar <mingo@kernel.org>
Thanks,
Ingo
next prev parent reply other threads:[~2013-05-10 7:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-09 19:23 [PATCH -v8 00/11] Shutdown from reboot_cpuid without stopping other cpus Robin Holt
2013-05-09 19:23 ` [PATCH -v9 01/11] CPU hotplug: Provide a generic helper to disable/enable CPU hotplug Robin Holt
2013-05-09 19:23 ` [PATCH -v9 02/11] Migrate shutdown/reboot to boot cpu Robin Holt
2013-05-09 19:23 ` [PATCH -v9 03/11] Remove -stable friendly PF_THREAD_BOUND define Robin Holt
2013-05-09 19:23 ` [PATCH -v9 04/11] Move shutdown/reboot related functions to kernel/reboot.c Robin Holt
2013-05-09 20:51 ` Andrew Morton
2013-05-10 0:05 ` Robin Holt
2013-05-10 9:50 ` Robin Holt
2013-05-09 19:23 ` [PATCH -v9 05/11] checkpatch.pl the new kernel/reboot.c file Robin Holt
2013-05-09 19:23 ` [PATCH -v9 06/11] x86, prepare reboot_mode for moving to generic kernel code Robin Holt
2013-05-09 19:23 ` [PATCH -v9 07/11] unicore32, " Robin Holt
2013-05-10 15:05 ` Xuetao Guan
2013-05-09 19:23 ` [PATCH -v9 08/11] arm, Remove unused restart_mode fields from some arm subarchs Robin Holt
2013-05-09 19:23 ` [PATCH -v9 09/11] arm, prepare reboot_mode for moving to generic kernel code Robin Holt
2013-05-09 19:23 ` [PATCH -v9 10/11] arm, change reboot_mode to use enum reboot_mode Robin Holt
2013-05-09 19:23 ` [PATCH -v9 11/11] Move arch/x86 reboot= handling to generic kernel Robin Holt
2013-05-10 7:06 ` Ingo Molnar [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-05-07 14:39 [PATCH -v8 00/11] Shutdown from reboot_cpuid without stopping other cpus Robin Holt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130510070616.GA5763@gmail.com \
--to=mingo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).