linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5] pinctrl: Add pinctrl-s3c24xx driver
Date: Sat, 11 May 2013 17:26:49 +0200	[thread overview]
Message-ID: <201305111726.49491.heiko@sntech.de> (raw)
In-Reply-To: <046401ce4d15$ccba0c80$662e2580$%kim@samsung.com>

Am Freitag, 10. Mai 2013, 02:32:05 schrieb Kukjin Kim:
> Heiko St?bner wrote:
> > The s3c24xx pins follow a similar pattern as the other Samsung SoCs and
> > can therefore reuse the already introduced infrastructure.
> > 
> > The s3c24xx SoCs have one design oddity in that the first 4 external
> > interrupts do not reside in the eint pending register but in the main
> > interrupt controller instead. We solve this by forwarding the external
> > interrupt from the main controller into the irq domain of the pin bank.
> > The masking/acking of these interrupts is handled in the same way.
> > 
> > Furthermore the S3C2412/2413 SoCs contain another oddity in that they
> > keep the same 4 eints in the main interrupt controller and eintpend
> > register and requiring ack operations to happen in both. This is solved
> > by using different compatible properties for the wakeup eint node which
> > set a property accordingly.
> > 
> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> > Reviewed-by: Tomasz Figa <t.figa@samsung.com>
> > Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> > Acked-by: Linus Walleij <linus.walleij@linaro.org>
> 
> Looks good to me.
> 
> Linus, if you want me to take into samsung tree, please let me know.

in v4 Linus said:

"Are you taking this through the Samsung tree?"

This would also enable me to put the s3c2416 devicetree support on top of it 
in this cycle, which of course needs the pinctrl driver.


Heiko

  reply	other threads:[~2013-05-11 15:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-03 13:52 [PATCH v5] pinctrl: Add pinctrl-s3c24xx driver Heiko Stübner
2013-05-10  0:32 ` Kukjin Kim
2013-05-11 15:26   ` Heiko Stübner [this message]
2013-05-11 15:28     ` Kukjin Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201305111726.49491.heiko@sntech.de \
    --to=heiko@sntech.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).