From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/5] ARM: dts: add SPI/NOR for mx6q{dl}-sabreauto boards
Date: Sun, 12 May 2013 16:43:39 +0200 [thread overview]
Message-ID: <20130512144339.GD31135@pengutronix.de> (raw)
In-Reply-To: <1368070143-1655-6-git-send-email-b32955@freescale.com>
On Thu, May 09, 2013 at 11:29:03AM +0800, Huang Shijie wrote:
> Since the SPI/NOR has pin conflict with the WEIM NOR,
> we disable the spi/nor by default.
>
> Signed-off-by: Huang Shijie <b32955@freescale.com>
> ---
> arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 32 ++++++++++++++++++++++++++++++
> 1 files changed, 32 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi b/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi
> index 7b561fb..b6b9e56 100644
> --- a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi
> @@ -16,6 +16,38 @@
> };
> };
>
> +&ecspi1 {
> + fsl,spi-num-chipselects = <1>;
> + cs-gpios = <&gpio3 19 0>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_ecspi1_1>;
> + status = "disabled";
> +
> + flash: m25p80 at 0 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "st,m25p32";
> + spi-max-frequency = <20000000>;
> + reg = <0>;
> +
> + partition at 0 {
> + label = "U-Boot";
> + reg = <0x0 0x40000>;
> + };
> +
> + partition at 40000 {
> + label = "U-Boot-ENV";
> + reg = <0x40000 0x10000>;
> + read-only;
> + };
> +
> + partition at 50000 {
> + label = "Kernel";
> + reg = <0x50000 0x3b0000>;
> + };
I really object to enforcing partition layouts in the devicetree. That's
clearly usecase specific and should be filled by the bootloader. Having
no partitions normally is not harmful, but having the wrong layout just
because we start a mainline devicetree really can be harmful.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2013-05-12 14:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-09 3:28 [PATCH 0/5] add SPI/NOR for imx6q{dl}-sabreauto boards Huang Shijie
2013-05-09 3:28 ` [PATCH 1/5] ARM: dts: imx6q: add a new device node for ecspi1 Huang Shijie
2013-05-09 10:38 ` Huang Shijie
2013-05-09 3:29 ` [PATCH 2/5] ARM: dts: imx6dl: add a pinctrl for eCSPI1 Huang Shijie
2013-05-09 3:29 ` [PATCH 3/5] ARM: dts: imx6dl: add a gpio for hog Huang Shijie
2013-05-09 3:29 ` [PATCH 4/5] ARM: dts: imx6q: " Huang Shijie
2013-05-09 3:29 ` [PATCH 5/5] ARM: dts: add SPI/NOR for mx6q{dl}-sabreauto boards Huang Shijie
2013-05-12 14:21 ` Shawn Guo
2013-05-12 14:43 ` Sascha Hauer [this message]
2013-05-12 15:18 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130512144339.GD31135@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).