linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: horms@verge.net.au (Simon Horman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] ARM: shmobile: r8a7790: Configure R-Car GPIO for IRQ_TYPE_EDGE_BOTH
Date: Tue, 14 May 2013 11:40:37 +0900	[thread overview]
Message-ID: <20130514024034.GA20239@verge.net.au> (raw)
In-Reply-To: <2257564.fgMO2c8G9k@avalon>

On Tue, May 14, 2013 at 12:33:42AM +0200, Laurent Pinchart wrote:
> Hi Simon,
> 
> On Monday 13 May 2013 17:53:52 Simon Horman wrote:
> > "gpio-rcar: Support IRQ_TYPE_EDGE_BOTH" adds support to the R-Car GPIO
> > driver for IRQ_TYPE_EDGE_BOTH. As hardware support for this feature is
> > not universal for all SoCs a flag, has_both_edge_trigger, has been
> > added to the platform data of the driver to allow this feature to be
> > enabled.
> 
> What about moving this information to a platform ID table in the gpio-rcar 
> driver ?

Magnus, do you have an opinion on this?

> > As the r8a7790 SoC hardware supports this feature enable it.
> > 
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > 
> > ---
> > 
> > This patch has a build-time dependency on
> > "gpio-rcar: Add support for IRQ_TYPE_EDGE_BOTH".
> > ---
> >  arch/arm/mach-shmobile/setup-r8a7790.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/arch/arm/mach-shmobile/setup-r8a7790.c
> > b/arch/arm/mach-shmobile/setup-r8a7790.c index eeef5f6..b461d93 100644
> > --- a/arch/arm/mach-shmobile/setup-r8a7790.c
> > +++ b/arch/arm/mach-shmobile/setup-r8a7790.c
> > @@ -45,6 +45,7 @@ static struct gpio_rcar_config
> > r8a7790_gpio##idx##_platform_data = {	\ .irq_base	= 0,						
> \
> >  	.number_of_pins	= 32,						\
> >  	.pctl_name	= "pfc-r8a7790",				\
> > +	.has_both_edge_trigger = 1,					\
> >  };									\
> > 
> >  R8A7790_GPIO(0);
> -- 
> Regards,
> 
> Laurent Pinchart
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

  reply	other threads:[~2013-05-14  2:40 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-13  8:53 [PATCH 0/3] ARM: mach-shmobile: lager: support GPIO switche Simon Horman
2013-05-13  8:53 ` [PATCH 1/3] gpio-rcar: Add support for IRQ_TYPE_EDGE_BOTH Simon Horman
2013-05-13 10:14   ` Magnus Damm
2013-05-14  2:44     ` Simon Horman
2013-05-13  8:53 ` [PATCH 2/3] ARM: shmobile: r8a7790: Configure R-Car GPIO " Simon Horman
2013-05-13 22:33   ` Laurent Pinchart
2013-05-14  2:40     ` Simon Horman [this message]
2013-05-14  6:01       ` Magnus Damm
2013-05-14 15:31         ` Laurent Pinchart
2013-05-13  8:53 ` [PATCH 3/3] ARM: mach-shmobile: lager: support GPIO switches Simon Horman
2013-05-13 13:25   ` Sergei Shtylyov
2013-05-13 22:35   ` Laurent Pinchart
2013-05-14  2:59     ` Simon Horman
2013-05-14  6:09       ` Magnus Damm
2013-05-14  8:38         ` Simon Horman
2013-05-14  9:24         ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130514024034.GA20239@verge.net.au \
    --to=horms@verge.net.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).