* [PATCH] ARM : omap : remove __init for _enable_preprogram
@ 2013-05-14 16:07 jp.francois at cynove.com
2013-05-14 18:08 ` Kevin Hilman
2013-05-14 18:26 ` Greg KH
0 siblings, 2 replies; 4+ messages in thread
From: jp.francois at cynove.com @ 2013-05-14 16:07 UTC (permalink / raw)
To: linux-arm-kernel
_enable_preprogram is marked as __init, but is called from _enable which is not.
This results in oops once init is freed.
Fix this by removing the __init marker.
Signed-off-by: Jean-Philippe Fran??ois <jp.francois@cynove.com>
Index: b/arch/arm/mach-omap2/omap_hwmod.c
===================================================================
--- a/arch/arm/mach-omap2/omap_hwmod.c
+++ b/arch/arm/mach-omap2/omap_hwmod.c
@@ -2066,7 +2066,7 @@
* do so is present in the hwmod data, then call it and pass along the
* return value; otherwise, return 0.
*/
-static int __init _enable_preprogram(struct omap_hwmod *oh)
+static int _enable_preprogram(struct omap_hwmod *oh)
{
if (!oh->class->enable_preprogram)
return 0;
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] ARM : omap : remove __init for _enable_preprogram
2013-05-14 16:07 [PATCH] ARM : omap : remove __init for _enable_preprogram jp.francois at cynove.com
@ 2013-05-14 18:08 ` Kevin Hilman
2013-05-16 18:15 ` Tony Lindgren
2013-05-14 18:26 ` Greg KH
1 sibling, 1 reply; 4+ messages in thread
From: Kevin Hilman @ 2013-05-14 18:08 UTC (permalink / raw)
To: linux-arm-kernel
jp.francois at cynove.com writes:
> _enable_preprogram is marked as __init, but is called from _enable which is not.
> This results in oops once init is freed.
> Fix this by removing the __init marker.
>
> Signed-off-by: Jean-Philippe Fran?ois <jp.francois@cynove.com>
Acked-by: Kevin Hilman <khilman@linaro.org>
Tony, this should probably be queued for v3.10-rc, and tagged for stable.
Kevin
> Index: b/arch/arm/mach-omap2/omap_hwmod.c
> ===================================================================
> --- a/arch/arm/mach-omap2/omap_hwmod.c
> +++ b/arch/arm/mach-omap2/omap_hwmod.c
> @@ -2066,7 +2066,7 @@
> * do so is present in the hwmod data, then call it and pass along the
> * return value; otherwise, return 0.
> */
> -static int __init _enable_preprogram(struct omap_hwmod *oh)
> +static int _enable_preprogram(struct omap_hwmod *oh)
> {
> if (!oh->class->enable_preprogram)
> return 0;
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] ARM : omap : remove __init for _enable_preprogram
2013-05-14 18:08 ` Kevin Hilman
@ 2013-05-16 18:15 ` Tony Lindgren
0 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2013-05-16 18:15 UTC (permalink / raw)
To: linux-arm-kernel
* Kevin Hilman <khilman@linaro.org> [130514 11:13]:
> jp.francois at cynove.com writes:
>
> > _enable_preprogram is marked as __init, but is called from _enable which is not.
> > This results in oops once init is freed.
> > Fix this by removing the __init marker.
> >
> > Signed-off-by: Jean-Philippe Fran?ois <jp.francois@cynove.com>
>
> Acked-by: Kevin Hilman <khilman@linaro.org>
>
> Tony, this should probably be queued for v3.10-rc, and tagged for stable.
Yes just applied the earlier version of this and added your
ack with cc: stable.
Regards,
Tony
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM : omap : remove __init for _enable_preprogram
2013-05-14 16:07 [PATCH] ARM : omap : remove __init for _enable_preprogram jp.francois at cynove.com
2013-05-14 18:08 ` Kevin Hilman
@ 2013-05-14 18:26 ` Greg KH
1 sibling, 0 replies; 4+ messages in thread
From: Greg KH @ 2013-05-14 18:26 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, May 14, 2013 at 06:07:01PM +0200, jp.francois at cynove.com wrote:
> _enable_preprogram is marked as __init, but is called from _enable which is not.
> This results in oops once init is freed.
> Fix this by removing the __init marker.
>
> Signed-off-by: Jean-Philippe Fran?ois <jp.francois@cynove.com>
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read Documentation/stable_kernel_rules.txt
for how to do this properly.
</formletter>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-05-16 18:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-14 16:07 [PATCH] ARM : omap : remove __init for _enable_preprogram jp.francois at cynove.com
2013-05-14 18:08 ` Kevin Hilman
2013-05-16 18:15 ` Tony Lindgren
2013-05-14 18:26 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).