From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2] arm: mm: Use phys_addr_t properly for ioremap functions
Date: Wed, 15 May 2013 16:15:39 +0200 [thread overview]
Message-ID: <201305151615.39752.arnd@arndb.de> (raw)
In-Reply-To: <1368560031-19367-1-git-send-email-lauraa@codeaurora.org>
On Tuesday 14 May 2013, Laura Abbott wrote:
> Several of the ioremap functions use unsigned long in places
> resulting in truncation if physical addresses greater than
> 4G are passed in. Change the types of the functions and the
> callers accordingly.
Looks good to me. I wonder a bit whether resource_size_t or phys_addr_t
is the right type here, but they are always defined to the same type
these days.
FWIW, x86 and tile use resource_size_t, while a couple of other architectures
use phys_addr_t.
Arnd
next prev parent reply other threads:[~2013-05-15 14:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-14 19:33 [PATCHv2] arm: mm: Use phys_addr_t properly for ioremap functions Laura Abbott
2013-05-15 14:15 ` Arnd Bergmann [this message]
2013-05-15 16:48 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201305151615.39752.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).