From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 03/39] dmaengine: ste_dma40: Don't configure runtime configurable setup during allocate
Date: Thu, 16 May 2013 12:06:40 +0530 [thread overview]
Message-ID: <20130516063640.GE14863@intel.com> (raw)
In-Reply-To: <1368611522-9984-4-git-send-email-lee.jones@linaro.org>
On Wed, May 15, 2013 at 10:51:26AM +0100, Lee Jones wrote:
> Using the dmaengine API, allocating and configuring a channel are two
> separate actions. Here we're removing logical channel configuration from
> the channel allocating routines.
>
> Cc: Vinod Koul <vinod.koul@intel.com>
> Cc: Dan Williams <djbw@fb.com>
> Cc: Per Forlin <per.forlin@stericsson.com>
> Cc: Rabin Vincent <rabin@rab.in>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
Acked-by: Vinod Koul <vinod.koul@intel.com>
--
~Vinod
> drivers/dma/ste_dma40.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
> index b7fe46b..ba84df8 100644
> --- a/drivers/dma/ste_dma40.c
> +++ b/drivers/dma/ste_dma40.c
> @@ -2040,6 +2040,9 @@ static int d40_config_memcpy(struct d40_chan *d40c)
> d40c->dma_cfg = dma40_memcpy_conf_log;
> d40c->dma_cfg.dev_type = dma40_memcpy_channels[d40c->chan.chan_id];
>
> + d40_log_cfg(&d40c->dma_cfg,
> + &d40c->log_def.lcsp1, &d40c->log_def.lcsp3);
> +
> } else if (dma_has_cap(DMA_MEMCPY, cap) &&
> dma_has_cap(DMA_SLAVE, cap)) {
> d40c->dma_cfg = dma40_memcpy_conf_phy;
> @@ -2508,9 +2511,6 @@ static int d40_alloc_chan_resources(struct dma_chan *chan)
> d40_set_prio_realtime(d40c);
>
> if (chan_is_logical(d40c)) {
> - d40_log_cfg(&d40c->dma_cfg,
> - &d40c->log_def.lcsp1, &d40c->log_def.lcsp3);
> -
> if (d40c->dma_cfg.dir == STEDMA40_PERIPH_TO_MEM)
> d40c->lcpa = d40c->base->lcpa_base +
> d40c->dma_cfg.dev_type * D40_LCPA_CHAN_SIZE;
> --
> 1.7.10.4
>
next prev parent reply other threads:[~2013-05-16 6:36 UTC|newest]
Thread overview: 126+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-15 9:51 [PATCH 00/39] Continuation of DMA changes in ux500 based drivers Lee Jones
2013-05-15 9:51 ` [PATCH 01/39] dmaengine: ste_dma40: Separate Logical Global Interrupt Mask (GIM) unmasking Lee Jones
2013-05-15 16:29 ` Linus Walleij
2013-05-16 6:35 ` Vinod Koul
2013-05-16 7:26 ` Lee Jones
2013-05-15 9:51 ` [PATCH 02/39] dmaengine: ste_dma40: Remove unnecessary call to d40_phy_cfg() Lee Jones
2013-05-15 16:33 ` Linus Walleij
2013-05-16 6:35 ` Vinod Koul
2013-05-16 7:25 ` Lee Jones
2013-05-16 9:40 ` Vinod Koul
2013-05-16 10:59 ` Lee Jones
2013-05-20 12:01 ` Linus Walleij
2013-05-15 9:51 ` [PATCH 03/39] dmaengine: ste_dma40: Don't configure runtime configurable setup during allocate Lee Jones
2013-05-15 16:44 ` Linus Walleij
2013-05-16 6:36 ` Vinod Koul [this message]
2013-05-15 9:51 ` [PATCH 04/39] ARM: ux500: Stop passing UART's platform data for Device Tree boots Lee Jones
2013-05-15 16:48 ` Linus Walleij
2013-05-15 9:51 ` [PATCH 05/39] ARM: ux500: Stop passing MMC's " Lee Jones
2013-05-15 16:50 ` Linus Walleij
2013-06-10 9:15 ` Lee Jones
2013-06-11 9:31 ` Linus Walleij
2013-05-15 9:51 ` [PATCH 06/39] ARM: ux500: Move SDI (MMC) and UART devices under more descriptive heading Lee Jones
2013-05-15 16:51 ` Linus Walleij
2013-06-10 9:17 ` Lee Jones
2013-06-11 9:40 ` Linus Walleij
2013-05-15 9:51 ` [PATCH 07/39] dmaengine: ste_dma40: Only use addresses passed as configuration information Lee Jones
2013-05-15 16:54 ` Linus Walleij
2013-05-16 6:40 ` Vinod Koul
2013-05-15 9:51 ` [PATCH 08/39] dmaengine: ste_dma40: Remove redundant address fetching function Lee Jones
2013-05-15 16:56 ` Linus Walleij
2013-05-16 6:41 ` Vinod Koul
2013-05-15 9:51 ` [PATCH 09/39] ARM: ux500: Remove DMA address look-up table Lee Jones
2013-05-15 17:03 ` Linus Walleij
2013-05-15 9:51 ` [PATCH 10/39] dmaengine: ste_dma40: Correct copy/paste error Lee Jones
2013-05-15 17:04 ` Linus Walleij
2013-05-16 6:42 ` Vinod Koul
2013-05-15 9:51 ` [PATCH 11/39] ARM: ux500: Remove unnecessary attributes from DMA channel request pdata Lee Jones
2013-05-15 17:05 ` Linus Walleij
2013-05-15 9:51 ` [PATCH 12/39] crypto: ux500/hash - Prepare clock before enabling it Lee Jones
2013-05-15 17:07 ` Linus Walleij
2013-05-16 6:53 ` Lee Jones
2013-05-16 7:00 ` Herbert Xu
2013-05-20 12:05 ` Linus Walleij
2013-05-15 9:51 ` [PATCH 13/39] crypto: ux500/hash - Set DMA configuration though dma_slave_config() Lee Jones
2013-05-15 17:09 ` Linus Walleij
2013-05-16 7:01 ` Herbert Xu
2013-05-20 12:06 ` Linus Walleij
2013-05-15 9:51 ` [PATCH 14/39] ARM: ux500: Stop passing Hash DMA channel config information though pdata Lee Jones
2013-05-20 12:09 ` Linus Walleij
2013-05-15 9:51 ` [PATCH 15/39] crypto: ux500/cryp - Prepare clock before enabling it Lee Jones
2013-05-15 17:11 ` Linus Walleij
2013-05-16 7:01 ` Herbert Xu
2013-05-20 12:10 ` Linus Walleij
2013-05-15 9:51 ` [PATCH 16/39] crypto: ux500/cryp - Set DMA configuration though dma_slave_config() Lee Jones
2013-05-16 7:01 ` Herbert Xu
2013-05-20 12:12 ` Linus Walleij
2013-05-15 9:51 ` [PATCH 17/39] ARM: ux500: Stop passing Cryp DMA channel config information though pdata Lee Jones
2013-05-15 9:51 ` [PATCH 18/39] crypto: ux500/[cryp|hash] - Show successful start-up in the bootlog Lee Jones
2013-05-16 7:02 ` Herbert Xu
2013-05-20 12:15 ` Linus Walleij
2013-05-15 9:51 ` [PATCH 19/39] ARM: ux500: Register Cyrp and Hash platform drivers on Snowball Lee Jones
2013-05-20 12:17 ` Linus Walleij
2013-05-15 9:51 ` [PATCH 20/39] usb: musb: ux500: move channel number knowledge into the driver Lee Jones
2013-05-15 17:18 ` Linus Walleij
2013-05-15 20:14 ` Fabio Baltieri
2013-05-17 6:35 ` Linus Walleij
2013-05-28 16:27 ` Felipe Balbi
2013-05-28 16:48 ` Lee Jones
2013-05-29 11:57 ` Linus Walleij
2013-05-20 12:19 ` Linus Walleij
2013-05-29 17:57 ` Felipe Balbi
2013-05-30 7:48 ` Linus Walleij
2013-05-30 8:12 ` Lee Jones
2013-05-30 19:06 ` Felipe Balbi
2013-05-30 7:44 ` Linus Walleij
2013-05-15 9:51 ` [PATCH 21/39] usb: musb: ux500: move the MUSB HDRC configuration " Lee Jones
2013-05-30 8:30 ` Linus Walleij
2013-05-15 9:51 ` [PATCH 22/39] usb: musb: ux500: take the dma_mask from coherent_dma_mask Lee Jones
2013-05-30 8:32 ` Linus Walleij
2013-05-15 9:51 ` [PATCH 23/39] usb: musb: ux500: harden checks for platform data Lee Jones
2013-05-30 8:34 ` Linus Walleij
2013-05-15 9:51 ` [PATCH 24/39] usb: musb: ux500: attempt to find channels by name before using pdata Lee Jones
2013-05-30 8:35 ` Linus Walleij
2013-05-15 9:51 ` [PATCH 25/39] usb: musb: ux500: add device tree probing support Lee Jones
2013-05-30 8:38 ` Linus Walleij
2013-05-15 9:51 ` [PATCH 26/39] ARM: ux500: Add an auxdata entry for MUSB for clock-name look-up Lee Jones
2013-05-30 8:42 ` Linus Walleij
2013-05-15 9:51 ` [PATCH 27/39] ARM: ux500: Remove ux500-musb platform registation when booting with DT Lee Jones
2013-05-30 8:44 ` Linus Walleij
2013-05-15 9:51 ` [PATCH 28/39] ARM: ux500: Remove empty function u8500_of_init_devices() Lee Jones
2013-05-30 8:45 ` Linus Walleij
2013-05-15 9:51 ` [PATCH 29/39] dmaengine: ste_dma40: Use the BIT macro to replace ugly '(1 << x)'s Lee Jones
2013-05-30 8:47 ` Linus Walleij
2013-05-15 9:51 ` [PATCH 30/39] ARM: ux500: Replace ST-E's home-brew DMA direction definition with the generic one Lee Jones
2013-05-30 8:52 ` Linus Walleij
2013-05-15 9:51 ` [PATCH 31/39] dmaengine: ste_dma40: Replace ST-E's home-brew DMA direction defs with generic ones Lee Jones
2013-05-16 5:17 ` Vinod Koul
2013-05-16 7:06 ` Lee Jones
2013-05-16 6:43 ` Vinod Koul
2013-05-30 8:54 ` Linus Walleij
2013-05-15 9:51 ` [PATCH 32/39] ARM: ux500: Remove recently unused stedma40_xfer_dir enums Lee Jones
2013-05-30 8:56 ` Linus Walleij
2013-05-15 9:51 ` [PATCH 33/39] dmaengine: ste_dma40_ll: Use the BIT macro to replace ugly '(1 << x)'s Lee Jones
2013-05-16 5:13 ` Vinod Koul
2013-05-30 8:58 ` Linus Walleij
2013-05-15 9:51 ` [PATCH 34/39] dmaengine: ste_dma40: Convert data_width from register bit format to value Lee Jones
2013-05-16 6:32 ` Vinod Koul
2013-05-16 7:35 ` Lee Jones
2013-05-16 9:41 ` Vinod Koul
2013-05-30 9:01 ` Linus Walleij
2013-05-15 9:51 ` [PATCH 35/39] dmaengine: ste_dma40_ll: Replace meaningless register set with comment Lee Jones
2013-05-16 5:18 ` Vinod Koul
2013-05-16 6:58 ` Lee Jones
2013-05-30 9:04 ` Linus Walleij
2013-05-30 17:56 ` Vinod Koul
2013-05-15 9:51 ` [PATCH 36/39] dmaengine: ste_dma40: Allow memcpy channels to be configured from DT Lee Jones
2013-05-16 5:05 ` Vinod Koul
2013-05-30 9:06 ` Linus Walleij
2013-05-15 9:52 ` [PATCH 37/39] ARM: ux500: Stop passing DMA platform data though AUXDATA Lee Jones
2013-05-30 9:12 ` Linus Walleij
2013-05-15 9:52 ` [PATCH 38/39] dmaengine: ste_dma40: Fetch the number of physical channels from DT Lee Jones
2013-05-16 6:34 ` Vinod Koul
2013-05-30 9:15 ` Linus Walleij
2013-05-15 9:52 ` [PATCH 39/39] dmaengine: ste_dma40: Fetch disabled " Lee Jones
2013-05-16 6:08 ` Vinod Koul
2013-05-30 9:16 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130516063640.GE14863@intel.com \
--to=vinod.koul@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).