linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: OMAP: Add usb_otg and glue data to OMAP3+ boards
Date: Thu, 16 May 2013 10:46:08 -0700	[thread overview]
Message-ID: <20130516174608.GC5600@atomide.com> (raw)
In-Reply-To: <5193296D.5040001@ti.com>

* Kishon Vijay Abraham I <kishon@ti.com> [130514 23:27]:
> On Saturday 11 May 2013 08:05 AM, Tony Lindgren wrote:
> >Commit ad871c10 (ARM: dts: OMAP: Add usb_otg and glue data to
> >OMAP3+ boards) added support for MUSB on omap3 for device tree,
> >but added the interrupts the wrong way probably as they were
> >copied from the omap4.dtsi file. On omap3 we have TI specific
> >interrupt controller, not GIC.
> >
> >Fix this by specifying the interrupt following the TI INTC
> >binding.
> >
> >Without this fix MUSB won't work as it is trying to use
> >irq0 instead of irq92.
> >
> >Signed-off-by: Tony Lindgren <tony@atomide.com>
> Tested in beagleboard-xm
> 
> Tested-by: Kishon Vijay Abraham I <kishon@ti.com>

Oops thanks, sorry I already pushed it out into omap-for-v3.10/dt-fixes
before noticing your tested-by.

Regards,

Tony

> >--- a/arch/arm/boot/dts/omap3.dtsi
> >+++ b/arch/arm/boot/dts/omap3.dtsi
> >@@ -516,7 +516,7 @@
> >  		usb_otg_hs: usb_otg_hs at 480ab000 {
> >  			compatible = "ti,omap3-musb";
> >  			reg = <0x480ab000 0x1000>;
> >-			interrupts = <0 92 0x4>, <0 93 0x4>;
> >+			interrupts = <92>, <93>;
> >  			interrupt-names = "mc", "dma";
> >  			ti,hwmods = "usb_otg_hs";
> >  			multipoint = <1>;
> >
> 

      reply	other threads:[~2013-05-16 17:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-11  2:35 [PATCH] ARM: dts: OMAP: Add usb_otg and glue data to OMAP3+ boards Tony Lindgren
2013-05-11  2:55 ` [PATCH] ARM: dts: Fix musb interrupt for device tree booting Tony Lindgren
2013-05-15  6:21 ` [PATCH] ARM: dts: OMAP: Add usb_otg and glue data to OMAP3+ boards Kishon Vijay Abraham I
2013-05-16 17:46   ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130516174608.GC5600@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).