From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH-V2] ARM: AM33XX: Add missing .clkdm_name to clkdiv32k_ick clock
Date: Fri, 17 May 2013 10:10:17 -0700 [thread overview]
Message-ID: <20130517171016.GV5600@atomide.com> (raw)
In-Reply-To: <79CD15C6BA57404B839C016229A409A83EC8BFA7@DBDE04.ent.ti.com>
* Hiremath, Vaibhav <hvaibhav@ti.com> [130517 03:36]:
>
> > -----Original Message-----
> > From: Paul Walmsley [mailto:paul at pwsan.com]
> > Sent: Wednesday, March 27, 2013 11:15 PM
> > To: Tony Lindgren; Hiremath, Vaibhav
> > Cc: linux-omap at vger.kernel.org; linux-arm-kernel at lists.infradead.org;
> > Nayak, Rajendra
> > Subject: Re: [PATCH-V2] ARM: AM33XX: Add missing .clkdm_name to
> > clkdiv32k_ick clock
> >
> > On Wed, 27 Mar 2013, Vaibhav Hiremath wrote:
> >
> > > It is required to enable respective clock-domain before
> > > enabling any clock/module inside that clock-domain.
> > >
> > > During common-clock migration, .clkdm_name field got missed
> > > for "clkdiv32k_ick" clock, which leaves "clk_24mhz_clkdm"
> > > unused; so it will be disabled even if childs of this clock-domain
> > > is enabled, which keeps child modules in idle mode.
> > >
> > > This fixes the kernel crash observed on AM335xEVM-SK platform,
> > > where clkdiv32_ick clock is being used as a gpio debounce clock
> > > and since clkdiv32k_ick is in idle mode it leads to below crash -
> > >
> > > Crash Log:
> > > ==========
> > > [ 2.598347] Unhandled fault: external abort on non-linefetch
> > (0x1028) at
> > > 0xfa1ac150
> > > [ 2.606434] Internal error: : 1028 [#1] SMP ARM
> > > [ 2.611207] Modules linked in:
> > > [ 2.614449] CPU: 0 Not tainted (3.8.4-01382-g1f449cd-dirty #4)
> > > [ 2.620973] PC is at _set_gpio_debounce+0x60/0x104
> > > [ 2.626025] LR is at clk_enable+0x30/0x3c
> > >
> > > Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
> > > Cc: Tony Lindgren <tony@atomide.com>
> > > Cc: Paul Walmsley <paul@pwsan.com>
> > > Cc: Rajendra Nayak <rnayak@ti.com>
> >
> > Acked-by: Paul Walmsley <paul@pwsan.com>
> >
> > Tony, if it isn't too late, could this one be added to your 3.9-rc
> > fixes
> > series?
> >
> >
>
> Looks like we missed this so far.
>
> Tony, can you merge this patch for v3.10-rc ?
Oops, sorry somehow this did not make it. I'll apply it to omap-for-v3.10/fixes
with cc: stable flag.
Regards,
Tony
next prev parent reply other threads:[~2013-05-17 17:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-27 10:04 [PATCH-V2] ARM: AM33XX: Add missing .clkdm_name to clkdiv32k_ick clock Vaibhav Hiremath
2013-03-27 17:45 ` Paul Walmsley
2013-03-27 20:19 ` Tony Lindgren
2013-05-17 10:30 ` Hiremath, Vaibhav
2013-05-17 17:10 ` Tony Lindgren [this message]
2013-05-20 5:51 ` Hiremath, Vaibhav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130517171016.GV5600@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).