* [PATCH] ARM: OMAP2+: AM33xx: Add missing reset status info to GFX hwmod
@ 2013-05-04 18:48 Vaibhav Hiremath
2013-05-17 11:08 ` Hiremath, Vaibhav
2013-06-09 7:14 ` Paul Walmsley
0 siblings, 2 replies; 5+ messages in thread
From: Vaibhav Hiremath @ 2013-05-04 18:48 UTC (permalink / raw)
To: linux-arm-kernel
GFX has a reset status register (PRM_GFX.RM_GFX_RSTST),
so update the GFX hwmod data with .rstst_off and .st_shift
information.
Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
Cc: Paul Walmsley <paul@pwsan.com>
---
arch/arm/mach-omap2/omap_hwmod_33xx_data.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
index d1cf3ab..38c7b04 100644
--- a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
@@ -329,7 +329,7 @@ static struct omap_hwmod_class am33xx_gfx_hwmod_class = {
};
static struct omap_hwmod_rst_info am33xx_gfx_resets[] = {
- { .name = "gfx", .rst_shift = 0 },
+ { .name = "gfx", .rst_shift = 0, .st_shift = 0},
};
static struct omap_hwmod_irq_info am33xx_gfx_irqs[] = {
@@ -347,6 +347,7 @@ static struct omap_hwmod am33xx_gfx_hwmod = {
.omap4 = {
.clkctrl_offs = AM33XX_CM_GFX_GFX_CLKCTRL_OFFSET,
.rstctrl_offs = AM33XX_RM_GFX_RSTCTRL_OFFSET,
+ .rstst_offs = AM33XX_RM_GFX_RSTST_OFFSET,
.modulemode = MODULEMODE_SWCTRL,
},
},
--
1.7.0.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] ARM: OMAP2+: AM33xx: Add missing reset status info to GFX hwmod
2013-05-04 18:48 [PATCH] ARM: OMAP2+: AM33xx: Add missing reset status info to GFX hwmod Vaibhav Hiremath
@ 2013-05-17 11:08 ` Hiremath, Vaibhav
2013-05-17 17:24 ` Tony Lindgren
2013-06-09 7:14 ` Paul Walmsley
1 sibling, 1 reply; 5+ messages in thread
From: Hiremath, Vaibhav @ 2013-05-17 11:08 UTC (permalink / raw)
To: linux-arm-kernel
> -----Original Message-----
> From: Hiremath, Vaibhav
> Sent: Sunday, May 05, 2013 12:18 AM
> To: linux-omap at vger.kernel.org
> Cc: tony at atomide.com; linux-arm-kernel at lists.infradead.org; Hiremath,
> Vaibhav; Paul Walmsley
> Subject: [PATCH] ARM: OMAP2+: AM33xx: Add missing reset status info to
> GFX hwmod
>
> GFX has a reset status register (PRM_GFX.RM_GFX_RSTST),
> so update the GFX hwmod data with .rstst_off and .st_shift
> information.
>
> Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
> Cc: Paul Walmsley <paul@pwsan.com>
> ---
> arch/arm/mach-omap2/omap_hwmod_33xx_data.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
> b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
> index d1cf3ab..38c7b04 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
> @@ -329,7 +329,7 @@ static struct omap_hwmod_class
> am33xx_gfx_hwmod_class = {
> };
>
> static struct omap_hwmod_rst_info am33xx_gfx_resets[] = {
> - { .name = "gfx", .rst_shift = 0 },
> + { .name = "gfx", .rst_shift = 0, .st_shift = 0},
> };
>
> static struct omap_hwmod_irq_info am33xx_gfx_irqs[] = {
> @@ -347,6 +347,7 @@ static struct omap_hwmod am33xx_gfx_hwmod = {
> .omap4 = {
> .clkctrl_offs = AM33XX_CM_GFX_GFX_CLKCTRL_OFFSET,
> .rstctrl_offs = AM33XX_RM_GFX_RSTCTRL_OFFSET,
> + .rstst_offs = AM33XX_RM_GFX_RSTST_OFFSET,
> .modulemode = MODULEMODE_SWCTRL,
> },
> },
> --
Tony and Paul,
Any Update on this one as well?
Thanks,
Vaibhav
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ARM: OMAP2+: AM33xx: Add missing reset status info to GFX hwmod
2013-05-17 11:08 ` Hiremath, Vaibhav
@ 2013-05-17 17:24 ` Tony Lindgren
2013-05-20 5:50 ` Hiremath, Vaibhav
0 siblings, 1 reply; 5+ messages in thread
From: Tony Lindgren @ 2013-05-17 17:24 UTC (permalink / raw)
To: linux-arm-kernel
* Hiremath, Vaibhav <hvaibhav@ti.com> [130517 04:13]:
>
> > -----Original Message-----
> > From: Hiremath, Vaibhav
> > Sent: Sunday, May 05, 2013 12:18 AM
> > To: linux-omap at vger.kernel.org
> > Cc: tony at atomide.com; linux-arm-kernel at lists.infradead.org; Hiremath,
> > Vaibhav; Paul Walmsley
> > Subject: [PATCH] ARM: OMAP2+: AM33xx: Add missing reset status info to
> > GFX hwmod
> >
> > GFX has a reset status register (PRM_GFX.RM_GFX_RSTST),
> > so update the GFX hwmod data with .rstst_off and .st_shift
> > information.
> >
> > Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
> > Cc: Paul Walmsley <paul@pwsan.com>
> > ---
> > arch/arm/mach-omap2/omap_hwmod_33xx_data.c | 3 ++-
> > 1 files changed, 2 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
> > b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
> > index d1cf3ab..38c7b04 100644
> > --- a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
> > +++ b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
> > @@ -329,7 +329,7 @@ static struct omap_hwmod_class
> > am33xx_gfx_hwmod_class = {
> > };
> >
> > static struct omap_hwmod_rst_info am33xx_gfx_resets[] = {
> > - { .name = "gfx", .rst_shift = 0 },
> > + { .name = "gfx", .rst_shift = 0, .st_shift = 0},
> > };
> >
> > static struct omap_hwmod_irq_info am33xx_gfx_irqs[] = {
> > @@ -347,6 +347,7 @@ static struct omap_hwmod am33xx_gfx_hwmod = {
> > .omap4 = {
> > .clkctrl_offs = AM33XX_CM_GFX_GFX_CLKCTRL_OFFSET,
> > .rstctrl_offs = AM33XX_RM_GFX_RSTCTRL_OFFSET,
> > + .rstst_offs = AM33XX_RM_GFX_RSTST_OFFSET,
> > .modulemode = MODULEMODE_SWCTRL,
> > },
> > },
> > --
>
> Tony and Paul,
>
> Any Update on this one as well?
Is this needed for v3.10 as a fix? If so, it should describe the
regression or error.
Regards,
Tony
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ARM: OMAP2+: AM33xx: Add missing reset status info to GFX hwmod
2013-05-17 17:24 ` Tony Lindgren
@ 2013-05-20 5:50 ` Hiremath, Vaibhav
0 siblings, 0 replies; 5+ messages in thread
From: Hiremath, Vaibhav @ 2013-05-20 5:50 UTC (permalink / raw)
To: linux-arm-kernel
> -----Original Message-----
> From: Tony Lindgren [mailto:tony at atomide.com]
> Sent: Friday, May 17, 2013 10:55 PM
> To: Hiremath, Vaibhav
> Cc: linux-omap at vger.kernel.org; linux-arm-kernel at lists.infradead.org;
> Paul Walmsley
> Subject: Re: [PATCH] ARM: OMAP2+: AM33xx: Add missing reset status info
> to GFX hwmod
>
> * Hiremath, Vaibhav <hvaibhav@ti.com> [130517 04:13]:
> >
> > > -----Original Message-----
> > > From: Hiremath, Vaibhav
> > > Sent: Sunday, May 05, 2013 12:18 AM
> > > To: linux-omap at vger.kernel.org
> > > Cc: tony at atomide.com; linux-arm-kernel at lists.infradead.org;
> Hiremath,
> > > Vaibhav; Paul Walmsley
> > > Subject: [PATCH] ARM: OMAP2+: AM33xx: Add missing reset status info
> to
> > > GFX hwmod
> > >
> > > GFX has a reset status register (PRM_GFX.RM_GFX_RSTST),
> > > so update the GFX hwmod data with .rstst_off and .st_shift
> > > information.
> > >
> > > Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
> > > Cc: Paul Walmsley <paul@pwsan.com>
> > > ---
> > > arch/arm/mach-omap2/omap_hwmod_33xx_data.c | 3 ++-
> > > 1 files changed, 2 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
> > > b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
> > > index d1cf3ab..38c7b04 100644
> > > --- a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
> > > +++ b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
> > > @@ -329,7 +329,7 @@ static struct omap_hwmod_class
> > > am33xx_gfx_hwmod_class = {
> > > };
> > >
> > > static struct omap_hwmod_rst_info am33xx_gfx_resets[] = {
> > > - { .name = "gfx", .rst_shift = 0 },
> > > + { .name = "gfx", .rst_shift = 0, .st_shift = 0},
> > > };
> > >
> > > static struct omap_hwmod_irq_info am33xx_gfx_irqs[] = {
> > > @@ -347,6 +347,7 @@ static struct omap_hwmod am33xx_gfx_hwmod = {
> > > .omap4 = {
> > > .clkctrl_offs = AM33XX_CM_GFX_GFX_CLKCTRL_OFFSET,
> > > .rstctrl_offs = AM33XX_RM_GFX_RSTCTRL_OFFSET,
> > > + .rstst_offs = AM33XX_RM_GFX_RSTST_OFFSET,
> > > .modulemode = MODULEMODE_SWCTRL,
> > > },
> > > },
> > > --
> >
> > Tony and Paul,
> >
> > Any Update on this one as well?
>
> Is this needed for v3.10 as a fix? If so, it should describe the
> regression or error.
>
Certainly this is fix, but no impact on kernel boot.
I will describe it more in the description and send next version shortly.
Thanks,
Vaibhav
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ARM: OMAP2+: AM33xx: Add missing reset status info to GFX hwmod
2013-05-04 18:48 [PATCH] ARM: OMAP2+: AM33xx: Add missing reset status info to GFX hwmod Vaibhav Hiremath
2013-05-17 11:08 ` Hiremath, Vaibhav
@ 2013-06-09 7:14 ` Paul Walmsley
1 sibling, 0 replies; 5+ messages in thread
From: Paul Walmsley @ 2013-06-09 7:14 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, 5 May 2013, Vaibhav Hiremath wrote:
> GFX has a reset status register (PRM_GFX.RM_GFX_RSTST),
> so update the GFX hwmod data with .rstst_off and .st_shift
> information.
>
> Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
> Cc: Paul Walmsley <paul@pwsan.com>
Thanks, queued.
- Paul
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-06-09 7:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-04 18:48 [PATCH] ARM: OMAP2+: AM33xx: Add missing reset status info to GFX hwmod Vaibhav Hiremath
2013-05-17 11:08 ` Hiremath, Vaibhav
2013-05-17 17:24 ` Tony Lindgren
2013-05-20 5:50 ` Hiremath, Vaibhav
2013-06-09 7:14 ` Paul Walmsley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).