From: moinejf@free.fr (Jean-Francois Moine)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC 4/4] DRM: tda998x: add missing include
Date: Sat, 18 May 2013 19:46:44 +0200 [thread overview]
Message-ID: <20130518194644.2a02a4fc@armhf> (raw)
In-Reply-To: <1368897139-25485-5-git-send-email-sebastian.hesselbarth@gmail.com>
On Sat, 18 May 2013 19:12:19 +0200
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> wrote:
> The RFC sent by Russell King was missing an include for tda998x. This
> is just a compatible clone to remember Russell to add that later.
>
> Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> ---
> Cc: Russell King <linux@arm.linux.org.uk>
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: dri-devel at lists.freedesktop.org
> Cc: Jason Cooper <jason@lakedaemon.net>
> Cc: Jean-Francois Moine <moinejf@free.fr>
> ---
> include/drm/i2c/tda998x.h | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
> create mode 100644 include/drm/i2c/tda998x.h
>
> diff --git a/include/drm/i2c/tda998x.h b/include/drm/i2c/tda998x.h
> new file mode 100644
> index 0000000..41f799f
> --- /dev/null
> +++ b/include/drm/i2c/tda998x.h
> @@ -0,0 +1,23 @@
> +#ifndef __TDA998X_H__
> +#define __TDA998X_H__
> +
> +enum tda998x_audio_format {
> + AFMT_I2S,
> + AFMT_SPDIF,
> +};
> +
> +struct tda998x_encoder_params {
> + int audio_cfg;
> + int audio_clk_cfg;
> + enum tda998x_audio_format audio_format;
> + int audio_sample_rate;
> + char audio_frame[6];
> + int swap_a, mirr_a;
> + int swap_b, mirr_b;
> + int swap_c, mirr_c;
> + int swap_d, mirr_d;
> + int swap_e, mirr_e;
> + int swap_f, mirr_f;
> +};
> +
> +#endif
These parameters should not be there. It seems to me that the DT is the
right place.
--
Ken ar c'henta? | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
next prev parent reply other threads:[~2013-05-18 17:46 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-16 19:25 [RFC 0/8] rmk's Dove DRM/TDA19988 Cubox driver Russell King - ARM Linux
2013-05-16 19:25 ` [RFC 1/8] DRM: Add Dove DRM driver Russell King
2013-05-16 19:25 ` [RFC 2/8] drm/i2c: nxp-tda998x: fix EDID reading on TDA19988 devices Russell King
2013-05-16 19:26 ` [RFC 3/8] drm/i2c: nxp-tda998x: ensure VIP output mux is properly set Russell King
2013-05-18 6:56 ` Jean-Francois Moine
2013-05-19 10:30 ` Russell King - ARM Linux
2013-05-16 19:26 ` [RFC 4/8] drm/i2c: nxp-tda998x: fix npix/nline programming Russell King
2013-05-16 19:26 ` [RFC 5/8] drm/i2c: nxp-tda998x: prepare for video input configuration Russell King
2013-05-16 19:27 ` [RFC 6/8] drm/i2c: nxp-tda998x: add video and audio " Russell King
2013-05-22 21:08 ` Rob Clark
2013-05-16 19:27 ` [RFC 7/8] DRM: Dove: add support for drm tda19988 driver Russell King
2013-05-16 19:27 ` [RFC 8/8] DRM: dove: provide a couple of generic slave encoder helpers Russell King
2013-05-17 11:33 ` [RFC 0/8] rmk's Dove DRM/TDA19988 Cubox driver Jean-Francois Moine
2013-05-17 11:58 ` Sebastian Hesselbarth
2013-05-17 12:01 ` Russell King - ARM Linux
2013-05-17 17:40 ` Jean-Francois Moine
2013-05-17 18:00 ` Russell King - ARM Linux
2013-05-17 18:05 ` Russell King - ARM Linux
2013-05-17 18:57 ` Jean-Francois Moine
2013-05-19 8:59 ` Russell King - ARM Linux
2013-05-20 13:36 ` Alex Deucher
2013-05-20 20:15 ` Russell King - ARM Linux
2013-05-20 20:23 ` Alex Deucher
2013-05-21 6:30 ` Jean-Francois Moine
2013-05-19 11:25 ` Russell King - ARM Linux
[not found] ` <1368897139-25485-1-git-send-email-sebastian.hesselbarth@gmail.com>
[not found] ` <1368897139-25485-3-git-send-email-sebastian.hesselbarth@gmail.com>
2013-05-18 17:33 ` [RFC 2/4] ARM: dove: add video card node for SolidRun CuBox Jean-Francois Moine
2013-05-18 18:33 ` Sebastian Hesselbarth
[not found] ` <1368897139-25485-4-git-send-email-sebastian.hesselbarth@gmail.com>
2013-05-18 17:45 ` [RFC 3/4] DRM: add OF support for Dove DRM driver Jean-Francois Moine
2013-05-18 18:20 ` Sebastian Hesselbarth
2013-05-18 19:18 ` Jean-Francois Moine
2013-05-20 10:16 ` Russell King - ARM Linux
2013-05-18 20:46 ` Russell King - ARM Linux
[not found] ` <1368897139-25485-5-git-send-email-sebastian.hesselbarth@gmail.com>
2013-05-18 17:46 ` Jean-Francois Moine [this message]
2013-05-18 18:21 ` [RFC 4/4] DRM: tda998x: add missing include Sebastian Hesselbarth
2013-05-18 18:23 ` Rob Clark
2013-05-18 18:58 ` Jean-Francois Moine
2013-05-18 19:11 ` Rob Clark
2013-05-18 19:30 ` Sebastian Hesselbarth
2013-05-18 20:26 ` Russell King - ARM Linux
2013-05-18 20:50 ` Sebastian Hesselbarth
2013-05-19 6:01 ` Jean-Francois Moine
2013-05-19 8:30 ` Sebastian Hesselbarth
2013-05-19 16:49 ` Jean-Francois Moine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130518194644.2a02a4fc@armhf \
--to=moinejf@free.fr \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox