linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 14/32] arm64: KVM: guest one-reg interface
Date: Tue, 21 May 2013 15:30:16 +0100	[thread overview]
Message-ID: <20130521143015.GF27002@arm.com> (raw)
In-Reply-To: <1368540840-26750-15-git-send-email-marc.zyngier@arm.com>

On Tue, May 14, 2013 at 03:13:42PM +0100, Marc Zyngier wrote:
> Let userspace play with the guest registers.
> 
> Reviewed-by: Christopher Covington <cov@codeaurora.org>
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
> --- /dev/null
> +++ b/arch/arm64/kvm/guest.c
...
> +static int get_core_reg(struct kvm_vcpu *vcpu, const struct kvm_one_reg *reg)
> +{
> +	__u32 __user *uaddr = (__u32 __user *)(unsigned long)reg->addr;
> +	struct kvm_regs *regs = vcpu_gp_regs(vcpu);
> +	int nr_regs = sizeof(*regs) / sizeof(__u32);

Was there any conclusion on using __u32 rather than __u64 here? At least
you should add a comment since it's slightly confusing.

-- 
Catalin

  reply	other threads:[~2013-05-21 14:30 UTC|newest]

Thread overview: 77+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-14 14:13 [PATCH v4 00/32] Port of KVM to arm64 Marc Zyngier
2013-05-14 14:13 ` [PATCH v4 01/32] arm64: KVM: define HYP and Stage-2 translation page flags Marc Zyngier
2013-05-20 14:29   ` Catalin Marinas
2013-05-14 14:13 ` [PATCH v4 02/32] arm64: KVM: HYP mode idmap support Marc Zyngier
2013-05-20 15:31   ` Catalin Marinas
2013-05-20 15:43     ` Marc Zyngier
2013-05-14 14:13 ` [PATCH v4 03/32] arm64: KVM: EL2 register definitions Marc Zyngier
2013-05-20 15:35   ` Catalin Marinas
2013-05-14 14:13 ` [PATCH v4 04/32] arm64: KVM: system register definitions for 64bit guests Marc Zyngier
2013-05-20 15:38   ` Catalin Marinas
2013-05-14 14:13 ` [PATCH v4 05/32] arm64: KVM: Basic ESR_EL2 helpers and vcpu register access Marc Zyngier
2013-05-20 15:41   ` Catalin Marinas
2013-05-20 15:45     ` Marc Zyngier
2013-05-14 14:13 ` [PATCH v4 06/32] arm64: KVM: fault injection into a guest Marc Zyngier
2013-05-20 15:53   ` Catalin Marinas
2013-05-14 14:13 ` [PATCH v4 07/32] arm64: KVM: architecture specific MMU backend Marc Zyngier
2013-05-20 15:57   ` Catalin Marinas
2013-05-20 16:17     ` Marc Zyngier
2013-05-20 16:25       ` Catalin Marinas
2013-05-20 16:27         ` Marc Zyngier
2013-05-14 14:13 ` [PATCH v4 08/32] arm64: KVM: user space interface Marc Zyngier
2013-05-20 16:01   ` Catalin Marinas
2013-05-14 14:13 ` [PATCH v4 09/32] arm64: KVM: system register handling Marc Zyngier
2013-05-20 16:21   ` Catalin Marinas
2013-05-14 14:13 ` [PATCH v4 10/32] arm64: KVM: CPU specific system registers handling Marc Zyngier
2013-05-20 16:26   ` Catalin Marinas
2013-05-14 14:13 ` [PATCH v4 11/32] arm64: KVM: virtual CPU reset Marc Zyngier
2013-05-20 16:27   ` Catalin Marinas
2013-05-14 14:13 ` [PATCH v4 12/32] arm64: KVM: kvm_arch and kvm_vcpu_arch definitions Marc Zyngier
2013-05-20 16:29   ` Catalin Marinas
2013-05-14 14:13 ` [PATCH v4 13/32] arm64: KVM: MMIO access backend Marc Zyngier
2013-05-21 13:19   ` Catalin Marinas
2013-05-14 14:13 ` [PATCH v4 14/32] arm64: KVM: guest one-reg interface Marc Zyngier
2013-05-21 14:30   ` Catalin Marinas [this message]
2013-05-21 14:36     ` Marc Zyngier
2013-05-14 14:13 ` [PATCH v4 15/32] arm64: KVM: hypervisor initialization code Marc Zyngier
2013-05-21 14:40   ` Catalin Marinas
2013-05-21 14:49     ` Marc Zyngier
2013-05-14 14:13 ` [PATCH v4 16/32] arm64: KVM: HYP mode world switch implementation Marc Zyngier
2013-05-21 15:16   ` Catalin Marinas
2013-05-21 16:43     ` Marc Zyngier
2013-05-14 14:13 ` [PATCH v4 17/32] arm64: KVM: Exit handling Marc Zyngier
2013-05-21 15:20   ` Catalin Marinas
2013-05-14 14:13 ` [PATCH v4 18/32] arm64: KVM: Plug the VGIC Marc Zyngier
2013-05-21 15:21   ` Catalin Marinas
2013-05-14 14:13 ` [PATCH v4 19/32] arm64: KVM: Plug the arch timer Marc Zyngier
2013-05-21 15:27   ` Catalin Marinas
2013-05-14 14:13 ` [PATCH v4 20/32] arm64: KVM: PSCI implementation Marc Zyngier
2013-05-21 15:38   ` Catalin Marinas
2013-05-14 14:13 ` [PATCH v4 21/32] arm64: KVM: Build system integration Marc Zyngier
2013-05-21 15:42   ` Catalin Marinas
2013-05-21 16:09     ` Paolo Bonzini
2013-05-21 16:14       ` Marc Zyngier
2013-05-22  8:42       ` Catalin Marinas
2013-05-22  8:45         ` Paolo Bonzini
2013-05-14 14:13 ` [PATCH v4 22/32] arm64: KVM: define 32bit specific registers Marc Zyngier
2013-05-23 10:46   ` Catalin Marinas
2013-05-14 14:13 ` [PATCH v4 23/32] arm64: KVM: 32bit GP register access Marc Zyngier
2013-05-23 10:48   ` Catalin Marinas
2013-05-14 14:13 ` [PATCH v4 24/32] arm64: KVM: 32bit conditional execution emulation Marc Zyngier
2013-05-23 10:53   ` Catalin Marinas
2013-05-14 14:13 ` [PATCH v4 25/32] arm64: KVM: 32bit handling of coprocessor traps Marc Zyngier
2013-05-23 11:00   ` Catalin Marinas
2013-05-14 14:13 ` [PATCH v4 26/32] arm64: KVM: CPU specific 32bit coprocessor access Marc Zyngier
2013-05-23 11:00   ` Catalin Marinas
2013-05-14 14:13 ` [PATCH v4 27/32] arm64: KVM: 32bit specific register world switch Marc Zyngier
2013-05-23 11:02   ` Catalin Marinas
2013-05-14 14:13 ` [PATCH v4 28/32] arm64: KVM: 32bit guest fault injection Marc Zyngier
2013-05-23 11:08   ` Catalin Marinas
2013-05-14 14:13 ` [PATCH v4 29/32] arm64: KVM: enable initialization of a 32bit vcpu Marc Zyngier
2013-05-23 11:08   ` Catalin Marinas
2013-05-14 14:13 ` [PATCH v4 30/32] arm64: KVM: userspace API documentation Marc Zyngier
2013-05-23 11:10   ` Catalin Marinas
2013-05-14 14:13 ` [PATCH v4 31/32] arm64: KVM: MAINTAINERS update Marc Zyngier
2013-05-21 15:44   ` Catalin Marinas
2013-05-14 14:14 ` [PATCH v4 32/32] arm64: KVM: document kernel object mappings in HYP Marc Zyngier
2013-05-23 11:12   ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130521143015.GF27002@arm.com \
    --to=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).