From: peterz@infradead.org (Peter Zijlstra)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] kernel/sched/core.c: need return NULL when BUG() is defined as empty.
Date: Wed, 22 May 2013 11:11:56 +0200 [thread overview]
Message-ID: <20130522091156.GC18810@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <5199D565.4070307@asianux.com>
On Mon, May 20, 2013 at 03:48:53PM +0800, Chen Gang wrote:
>
> When neither CONFIG_BUG nor HAVE_ARCH_BUG is defined, need let function
> return failure value ('NULL') instead of random value.
What will such a kernel do? Happily continue running whenever we hit a
BUG? that seems like a particularly bad idea. Should we not have a stub
BUG() function like:
void BUG(void) __attribute__((noreturn))
{
local_irq_disable();
while (1) ;
}
Which would at least halt things?
next prev parent reply other threads:[~2013-05-22 9:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-20 7:48 [PATCH] kernel/sched/core.c: need return NULL when BUG() is defined as empty Chen Gang
2013-05-22 9:11 ` Peter Zijlstra [this message]
2013-05-22 9:29 ` Chen Gang
2013-05-22 13:33 ` Russell King - ARM Linux
2013-05-22 16:19 ` Peter Zijlstra
2013-05-23 1:00 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130522091156.GC18810@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).