From: morten.rasmussen@arm.com (Morten Rasmussen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 13/14] sched: update the cpu_power
Date: Wed, 22 May 2013 16:46:39 +0100 [thread overview]
Message-ID: <20130522154639.GA4935@e103034-lin> (raw)
In-Reply-To: <1366910611-20048-14-git-send-email-vincent.guittot@linaro.org>
On Thu, Apr 25, 2013 at 06:23:29PM +0100, Vincent Guittot wrote:
> @@ -4596,8 +4597,12 @@ static void update_cpu_power(struct sched_domain *sd, int cpu)
> cpu_rq(cpu)->cpu_available = power;
> sdg->sgp->power_available = power;
>
> + if (!is_my_buddy(cpu, cpu))
> + power = 1;
> +
Using your fix for is_my_buddy() for patch 11 the above will always be
true when sched_packing_mode is to anything else than
SCHED_PACKING_FULL. So cpu_power for all cpus in
SCHED_PACKING_{DEFAULT,NONE} is 1.
As far is I understand, this is not the intention?
Cheers,
Morten
> cpu_rq(cpu)->cpu_power = power;
> sdg->sgp->power = power;
> +
> }
>
> void update_group_power(struct sched_domain *sd, int cpu)
> --
> 1.7.9.5
>
>
next prev parent reply other threads:[~2013-05-22 15:46 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-25 17:23 [RFC PATCH v4 00/14] sched: packing small tasks Vincent Guittot
2013-04-25 17:23 ` [PATCH 01/14] Revert "sched: Introduce temporary FAIR_GROUP_SCHED dependency for load-tracking" Vincent Guittot
2013-04-25 17:23 ` [PATCH 02/14] sched: add a new SD_SHARE_POWERDOMAIN flag for sched_domain Vincent Guittot
2013-04-25 17:23 ` [PATCH 03/14] sched: pack small tasks Vincent Guittot
2013-04-26 12:30 ` Peter Zijlstra
2013-04-26 13:16 ` Vincent Guittot
2013-04-26 12:38 ` Peter Zijlstra
2013-04-26 13:38 ` Vincent Guittot
2013-04-25 17:23 ` [PATCH 04/14] sched: pack the idle load balance Vincent Guittot
2013-04-26 12:49 ` Peter Zijlstra
2013-04-26 13:47 ` Vincent Guittot
2013-04-25 17:23 ` [PATCH 05/14] ARM: sched: clear SD_SHARE_POWERDOMAIN Vincent Guittot
2013-04-25 17:23 ` [PATCH 06/14] sched: add a knob to choose the packing level Vincent Guittot
2013-04-25 17:23 ` [PATCH 07/14] sched: agressively pack at wake/fork/exec Vincent Guittot
2013-04-26 13:08 ` Peter Zijlstra
2013-04-26 14:23 ` Vincent Guittot
2013-04-25 17:23 ` [PATCH 08/14] sched: trig ILB on an idle buddy Vincent Guittot
2013-04-26 13:15 ` Peter Zijlstra
2013-04-26 14:52 ` Vincent Guittot
2013-04-25 17:23 ` [PATCH 09/14] sched: evaluate the activity level of the system Vincent Guittot
2013-05-22 16:50 ` Morten Rasmussen
2013-05-23 8:11 ` Vincent Guittot
2013-04-25 17:23 ` [PATCH 10/14] sched: update the buddy CPU Vincent Guittot
2013-04-28 8:20 ` Francesco Lavra
2013-04-29 7:32 ` Vincent Guittot
2013-04-25 17:23 ` [PATCH 11/14] sched: filter task pull request Vincent Guittot
2013-04-26 10:00 ` Vincent Guittot
2013-05-22 15:56 ` Morten Rasmussen
2013-05-22 16:03 ` Vincent Guittot
2013-04-25 17:23 ` [PATCH 12/14] sched: create a new field with available capacity Vincent Guittot
2013-04-25 17:23 ` [PATCH 13/14] sched: update the cpu_power Vincent Guittot
2013-05-22 15:46 ` Morten Rasmussen [this message]
2013-05-22 15:58 ` Vincent Guittot
2013-04-25 17:23 ` [PATCH 14/14] sched: force migration on buddy CPU Vincent Guittot
2013-04-26 12:08 ` [RFC PATCH v4 00/14] sched: packing small tasks Vincent Guittot
2013-04-26 15:00 ` Arjan van de Ven
2013-04-26 15:40 ` Vincent Guittot
2013-04-26 15:46 ` Arjan van de Ven
2013-04-26 15:56 ` Vincent Guittot
2013-05-02 9:12 ` Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130522154639.GA4935@e103034-lin \
--to=morten.rasmussen@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox