From: akpm@linux-foundation.org (Andrew Morton)
To: linux-arm-kernel@lists.infradead.org
Subject: [rtc-linux] [PATCH] rtc: max8998: Check for pdata presence before dereferencing
Date: Thu, 23 May 2013 16:55:04 -0700 [thread overview]
Message-ID: <20130523165504.364bebf5f999e4a12d51e176@linux-foundation.org> (raw)
In-Reply-To: <1368630968-30460-1-git-send-email-t.figa@samsung.com>
On Wed, 15 May 2013 17:16:08 +0200 Tomasz Figa <t.figa@samsung.com> wrote:
> Currently the driver can crash with a NULL pointer dereference if no pdata
> is provided, despite of successful registration of MFD part. This patch
> fixes the problem by adding a NULL check before dereferencing the pdata
> pointer.
>
> ...
>
> --- a/drivers/rtc/rtc-max8998.c
> +++ b/drivers/rtc/rtc-max8998.c
> @@ -285,7 +285,7 @@ static int max8998_rtc_probe(struct platform_device *pdev)
> info->irq, ret);
>
> dev_info(&pdev->dev, "RTC CHIP NAME: %s\n", pdev->id_entry->name);
> - if (pdata->rtc_delay) {
> + if (pdata && pdata->rtc_delay) {
> info->lp3974_bug_workaround = true;
> dev_warn(&pdev->dev, "LP3974 with RTC REGERR option."
> " RTC updates will be extremely slow.\n");
Looking at your description I'm unable to determine which kernel
versions we should fix. This is because the changelog didn't describe
the circumstances under which the bug triggers.
It's pretty simple: when fixing a bug, include a full description of
the bug! As if you were sending a bug report, not a patch.
prev parent reply other threads:[~2013-05-23 23:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-15 15:16 [PATCH] rtc: max8998: Check for pdata presence before dereferencing Tomasz Figa
2013-05-15 16:12 ` Sachin Kamat
2013-05-20 20:05 ` Tomasz Figa
2013-05-23 23:55 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130523165504.364bebf5f999e4a12d51e176@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox