From: w@1wt.eu (Willy Tarreau)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: mvebu: Fix bug in coherency fabric low level init function
Date: Thu, 23 May 2013 20:15:19 +0200 [thread overview]
Message-ID: <20130523181519.GF2680@1wt.eu> (raw)
In-Reply-To: <1369299242-16506-2-git-send-email-gregory.clement@free-electrons.com>
Hi Gregory,
On Thu, May 23, 2013 at 10:54:02AM +0200, Gregory CLEMENT wrote:
> From: Nadav Haklai <nadavh@marvell.com>
>
> When adding CPU to the SMP group and enabling the coherency on this
> CPU we must protect the register access.
> The previous implementation claims to be atomic but doesn't provide
> any protection against parallel access to the coherency fabric control
> and configuration registers.
>
> This patch fixes this by using the ldrex and strex mechanism.
> This method should be used in all accesses to those registers.
I don't know how to tell whether the fix works since it's unclear
to me what issue it fixes, but at least I can say that it doesn't
break my armada370 on 3.10-rc2 + latest fixes from your dev branch.
Best regards,
Willy
prev parent reply other threads:[~2013-05-23 18:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-23 8:54 [PATCH for 3.10-rc] ARM: mvebu: Fix bug in coherency fabric low level init function Gregory CLEMENT
2013-05-23 8:54 ` [PATCH] " Gregory CLEMENT
2013-05-23 17:42 ` Jason Cooper
2013-05-23 18:15 ` Willy Tarreau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130523181519.GF2680@1wt.eu \
--to=w@1wt.eu \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).