linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/4] Marvell PCIe driver improvements
Date: Thu, 23 May 2013 20:57:26 +0200	[thread overview]
Message-ID: <20130523205726.05ba45bf@skate> (raw)
In-Reply-To: <20130523164654.GA31281@obsidianresearch.com>

Dear Jason Gunthorpe,

On Thu, 23 May 2013 10:46:54 -0600, Jason Gunthorpe wrote:

> > FWIW, these patches applied on top of your pcie-v10 tree have made
> > my mini-pcie dual-nic appear for the first time on the mirabox. Till
> > now I never knew if it was a hardware or software issue since the NIC
> > does not appear in u-boot nor lspci, whatever the kernel versions,
> > including the original Marvell one's. The NIC has two functions (one
> > per controller) and no bridge, so it may be a side effect of your
> > improvements (or maybe you fixed a bug).
> 
> There was some talk earlier that some buggy chips required their
> device number to be 0. I'm guessing Thomas's change to ensure that
> always happens by moving the device number of the internal device is
> the root fix here?

You're correct. Off-list, I've sent to Willy a patch that applies on
top of those additional "bridge-related" fixes, but that reverts back
the slot number of the real PCIe device to be 1 instead of 0. And in
this case, the PCIe device that Willy is using is not detected.

So indeed, there are some PCIe devices who really want to receive
"configuration transactions" as slot 0.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

      reply	other threads:[~2013-05-23 18:57 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-22 13:12 [PATCH 0/4] Marvell PCIe driver improvements Thomas Petazzoni
2013-05-22 13:12 ` [PATCH 1/4] pci: mvebu: no longer fake the slot location of downstream devices Thomas Petazzoni
2013-05-22 13:12 ` [PATCH 2/4] pci: mvebu: allow the enumeration of devices beyond physical bridges Thomas Petazzoni
2013-05-22 14:31   ` Bjorn Helgaas
2013-05-22 13:12 ` [PATCH 3/4] pci: mvebu: emulate an empty capability list Thomas Petazzoni
2013-05-22 14:39   ` Bjorn Helgaas
2013-05-22 14:55     ` Thomas Petazzoni
2013-05-22 13:12 ` [PATCH 4/4] pci: mvebu: fix the emulation of the status register Thomas Petazzoni
2013-05-22 14:49   ` Bjorn Helgaas
2013-05-22 13:43 ` [PATCH 0/4] Marvell PCIe driver improvements Jason Cooper
2013-05-22 15:09   ` Gregory CLEMENT
2013-05-22 15:18     ` Jason Cooper
2013-05-23  0:13 ` Willy Tarreau
2013-05-23  6:35   ` Thomas Petazzoni
2013-05-23  6:52     ` Willy Tarreau
2013-05-23 16:46   ` Jason Gunthorpe
2013-05-23 18:57     ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130523205726.05ba45bf@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).