From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 0/2] dma: imx-sdma: add generic DMA device tree bindings support
Date: Fri, 24 May 2013 11:02:23 +0530 [thread overview]
Message-ID: <20130524053223.GQ30200@intel.com> (raw)
In-Reply-To: <20130524055338.GG2704@S2101-09.ap.freescale.net>
On Fri, May 24, 2013 at 01:53:41PM +0800, Shawn Guo wrote:
> On Fri, May 24, 2013 at 10:33:29AM +0530, Vinod Koul wrote:
> > On Fri, May 24, 2013 at 01:29:05PM +0800, Shawn Guo wrote:
> > > Vinod,
> > >
> > > On Thu, Apr 25, 2013 at 10:43:26PM +0800, Shawn Guo wrote:
> > > > Changes since v1:
> > > > * Fix the example typo in bindings doc. Thanks to Fabio.
> > > >
> > > > Shawn Guo (2):
> > > > dma: imx: change enum definitions to macros
> > > > dma: imx-sdma: move to generic device tree bindings
> > >
> > > Can you please apply these for 3.11?
> > Sorry I was thinking that you will update the patchset based on Arnd last
> > comment on (ab)use of macro. Can you fix that & resend
>
> I had a response [1] on that to explain why I think the macro is
> being reasonably used there.
I see the reason for this. Arnd replied to me only. I think an honest mistake.
Here are his comments
> > Looks fine to me, Arnd?
>
> I still think that the move of the numbers to include/dt-bindings/dma/imx.h
> is abuse of the preprocessor infrastructure and should not be there.
> The actual binding looks fine though.
>
> Arnd
>
What I didnt realize that it was not on list and you havent seen it.
Can you fix this up and resend...
--
~Vinod
>
prev parent reply other threads:[~2013-05-24 5:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-25 14:43 [PATCH v2 0/2] dma: imx-sdma: add generic DMA device tree bindings support Shawn Guo
2013-04-25 14:43 ` [PATCH v2 1/2] dma: imx: change enum definitions to macros Shawn Guo
2013-04-25 14:43 ` [PATCH v2 2/2] dma: imx-sdma: move to generic device tree bindings Shawn Guo
2013-04-30 10:51 ` Vinod Koul
2013-05-07 2:56 ` Shawn Guo
2013-05-24 5:29 ` [PATCH v2 0/2] dma: imx-sdma: add generic DMA device tree bindings support Shawn Guo
2013-05-24 5:03 ` Vinod Koul
2013-05-24 5:53 ` Shawn Guo
2013-05-24 5:32 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130524053223.GQ30200@intel.com \
--to=vinod.koul@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).