From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Fri, 24 May 2013 09:24:28 +0100 Subject: [PATCH] ARM: ux500: Only configure wake-up reasons on ux500 based platforms In-Reply-To: References: <1368702935-25599-1-git-send-email-lee.jones@linaro.org> Message-ID: <20130524082428.GO22683@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, 24 May 2013, Linus Walleij wrote: > On Thu, May 16, 2013 at 1:15 PM, Lee Jones wrote: > > > Multiplatform calls all enabled platforms' initcalls. In the > > ux500_idle_init() initcall we call into the DBx500-PRCMU which in turn > > executes some ux500 specific register reads/writes. When running on > > some !ux500 platforms this ends up causing a kernel Oops. This patch > > ensures the PRCMU call is only invoked when running on ux500 based > > platforms. > > > > Reported-by: Rob Herring > > Signed-off-by: Lee Jones > > Patch applied for ux500 fixes. > > Hm, again and again I get so confused by this, don't you say > "wakeup CAUSE" rather than "wakeup REASON"? > > Maybe I don't know the anglo saxon well enough... The words 'cause' and 'reason' are fairly synonymous and are interchangeable in a great many situations. You have to be an English literary Nazi to care enough to work out the semantics, which in case you hadn't noticed, I'm not. :) But, credit where credit's due, in this particular instance you are correct. Feel free to fixup. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog