public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: mturquette@linaro.org (Mike Turquette)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] clk: si5351: Fix clkout rate computation.
Date: Wed, 29 May 2013 15:11:50 -0700	[thread overview]
Message-ID: <20130529221150.6058.5735@quantum> (raw)
In-Reply-To: <51949076.9040008@streamunlimited.com>

Quoting Marek Belisko (2013-05-16 00:53:26)
> On 05/14/2013 09:16 PM, Mike Turquette wrote:
> > Quoting Marek Belisko (2013-05-02 22:53:22)
> >> Rate was incorrectly computed because we read from wrong divider register.
> >>
> >> Signed-off-by: Marek Belisko <marek.belisko@streamunlimited.com>
> >> Acked-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> >
> > Do either of these patches need to go into clk-fixes?  If so please be
> > explicit about it in the changelog, the section under the three dashes.
> Yes I believe they should go to clk-fixes (probably also to linux-stable).

Pulled both into clk-fixes.  I added the missing changelog to patch #2
because I am such a nice guy.

Regards,
Mike

> >
> > Regards,
> > Mike
> >
> >> ---
> >>   drivers/clk/clk-si5351.c |    2 +-
> >>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/clk/clk-si5351.c b/drivers/clk/clk-si5351.c
> >> index 8927284..cf39e53 100644
> >> --- a/drivers/clk/clk-si5351.c
> >> +++ b/drivers/clk/clk-si5351.c
> >> @@ -932,7 +932,7 @@ static unsigned long si5351_clkout_recalc_rate(struct clk_hw *hw,
> >>          unsigned char reg;
> >>          unsigned char rdiv;
> >>
> >> -       if (hwdata->num > 5)
> >> +       if (hwdata->num <= 5)
> >>                  reg = si5351_msynth_params_address(hwdata->num) + 2;
> >>          else
> >>                  reg = SI5351_CLK6_7_OUTPUT_DIVIDER;
> >> --
> >> 1.7.9.5
> >
> 
> Regards,
> 
> Marek
> -- 
> Marek Belisko
> 
> Software Developer
> StreamUnlimited Engineering GmbH
> Gutheil Schodergasse 8-12
> A-1100 Vienna, Austria
> 
> Office: +421 267200087
> 
> e-mail: marek.belisko at streamunlimited.com
> http://www.streamunlimited.com
> 
> Meet us at:
> 
> IFA - Berlin, 6-11 September
> CEDIA - Denver, 25-28 September

      reply	other threads:[~2013-05-29 22:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-03  5:53 [PATCH v2 1/2] clk: si5351: Fix clkout rate computation Marek Belisko
2013-05-03  5:53 ` [PATCH v2 2/2] clk: si5351: Set initial clkout rate when defined in platform data Marek Belisko
2013-05-03 10:05   ` Sebastian Hesselbarth
2013-05-14 19:16 ` [PATCH v2 1/2] clk: si5351: Fix clkout rate computation Mike Turquette
2013-05-16  7:53   ` Marek Belisko
2013-05-29 22:11     ` Mike Turquette [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130529221150.6058.5735@quantum \
    --to=mturquette@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox