public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V1] ARM: mm: lazy cache flushing on non-mapped pages
Date: Fri, 31 May 2013 09:47:03 +0100	[thread overview]
Message-ID: <20130531084703.GC4928@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <CACVXFVNL032TY7b=YHEg9aaT_WNW3R8JOzaVqSbq09t2kcVOQg@mail.gmail.com>

On Fri, May 31, 2013 at 05:31:59AM +0100, Ming Lei wrote:
> On Thu, May 30, 2013 at 11:40 PM, Will Deacon <will.deacon@arm.com> wrote:
> > Does the page_mapped test make the mapping_mapped test redundant? It sounds
> > strange if it's possible to get a non-zero mapcount for a page when its
> > address space isn't mapped.
> 
> Yes, page_mapped() should always return correct value for a page in page
> cache.
> 
> I keep the previous check just for safe reason, and I can remove it if
> you care.

I think it makes the code clearer and removes a check, so yes please.

Will

  reply	other threads:[~2013-05-31  8:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-29 14:56 [PATCH V1] ARM: mm: lazy cache flushing on non-mapped pages Ming Lei
2013-05-30 15:40 ` Will Deacon
2013-05-31  4:31   ` Ming Lei
2013-05-31  8:47     ` Will Deacon [this message]
2013-05-31  9:10       ` Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130531084703.GC4928@mudshark.cambridge.arm.com \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox