[PATCH] mfd: twl-core: convert to module_init()

[PATCH] mfd: twl-core: convert to module_init()

[Kevin Hilman]

There's no reason for twl-core to be subsys_inicall anymore.  Anything
using twl that early needs a rethink, or deferred probe changes.

Boot tested and RTC wake tested (via TWL RTC) on OMAP platforms:
3530/Beagle, 3730/Beagle-xM, 3530/Overo, 3730/Overo-STORM, 4430/Panda,
4460/Panda-ES.

Cc: Tony Lindgren <tony@atomide.com>
Signed-off-by: Kevin Hilman <khilman@linaro.org>
---
 drivers/mfd/twl-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c
index 89ab4d9..7749b9e 100644
--- a/drivers/mfd/twl-core.c
+++ b/drivers/mfd/twl-core.c
@@ -1309,7 +1309,7 @@ static int __init twl_init(void)
 {
 	return i2c_add_driver(&twl_driver);
 }
-subsys_initcall(twl_init);
+module_init(twl_init);
 
 static void __exit twl_exit(void)
 {
-- 
1.8.2

[PATCH] mfd: twl-core: convert to module_init()

[Tony Lindgren]

* Kevin Hilman <khilman@linaro.org> [130531 14:02]:
> There's no reason for twl-core to be subsys_inicall anymore.  Anything
> using twl that early needs a rethink, or deferred probe changes.
> 
> Boot tested and RTC wake tested (via TWL RTC) on OMAP platforms:
> 3530/Beagle, 3730/Beagle-xM, 3530/Overo, 3730/Overo-STORM, 4430/Panda,
> 4460/Panda-ES.
> 
> Cc: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Kevin Hilman <khilman@linaro.org>

Totally agree:

Acked-by: Tony Lindgren <tony@atomide.com>

> ---
>  drivers/mfd/twl-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c
> index 89ab4d9..7749b9e 100644
> --- a/drivers/mfd/twl-core.c
> +++ b/drivers/mfd/twl-core.c
> @@ -1309,7 +1309,7 @@ static int __init twl_init(void)
>  {
>  	return i2c_add_driver(&twl_driver);
>  }
> -subsys_initcall(twl_init);
> +module_init(twl_init);
>  
>  static void __exit twl_exit(void)
>  {
> -- 
> 1.8.2
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] mfd: twl-core: convert to module_init()

[Strashko, Grygorii]

Hi Kevin,

It's done alreday here:
https://patchwork.kernel.org/patch/2477541/ - mfd: twl-core: convert to module_i2c_driver()
 (Samuel has taken this one)
- and -
https://patchwork.kernel.org/patch/2477561/ - i2c: omap: convert to module_platform_driver()
 (you can vote here - TWL can't be shifted without I2C)

(Sent from Web Outlook - sorry if format is wrong)
Best regards,
- Grygorii Strashko 

________________________________________
From: linux-omap-owner@vger.kernel.org [linux-omap-owner at vger.kernel.org] on behalf of Kevin Hilman [khilman at linaro.org]
Sent: Friday, May 31, 2013 11:56 PM
To: Samuel Ortiz; Tony Lindgren
Cc: linux-omap at vger.kernel.org; linux-arm-kernel at lists.infradead.org; open list
Subject: [PATCH] mfd: twl-core: convert to module_init()

There's no reason for twl-core to be subsys_inicall anymore.  Anything
using twl that early needs a rethink, or deferred probe changes.

Boot tested and RTC wake tested (via TWL RTC) on OMAP platforms:
3530/Beagle, 3730/Beagle-xM, 3530/Overo, 3730/Overo-STORM, 4430/Panda,
4460/Panda-ES.

Cc: Tony Lindgren <tony@atomide.com>
Signed-off-by: Kevin Hilman <khilman@linaro.org>
---
 drivers/mfd/twl-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c
index 89ab4d9..7749b9e 100644
--- a/drivers/mfd/twl-core.c
+++ b/drivers/mfd/twl-core.c
@@ -1309,7 +1309,7 @@ static int __init twl_init(void)
 {
        return i2c_add_driver(&twl_driver);
 }
-subsys_initcall(twl_init);
+module_init(twl_init);

 static void __exit twl_exit(void)
 {
--
1.8.2

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] mfd: twl-core: convert to module_init()

[Kevin Hilman]

"Strashko, Grygorii" <grygorii.strashko@ti.com> writes:

> Hi Kevin,
>
> It's done alreday here:
> https://patchwork.kernel.org/patch/2477541/ - mfd: twl-core: convert to module_i2c_driver()
>  (Samuel has taken this one)

Excellent, thanks for pointing it out, somehow I missed that thread.  My
patch can be ignored.

> - and -
> https://patchwork.kernel.org/patch/2477561/ - i2c: omap: convert to module_platform_driver()
>  (you can vote here - TWL can't be shifted without I2C)

This one (combined with the first one) makes twl_rtc fail to initialize
properly on OMAP3 DT boot, with an error like this:

         twl_rtc rtc.22: hctosys: invalid date/time

Reverting that you get the expected result:

          twl_rtc rtc.22: setting system clock to 2000-01-01 00:00:00 UTC (946684800)

I didn't debug any further, but for now, at least patch 2 needs a little
more work/debug.

Kevin