* [PATCH] ARM: ux500: register LP5521 LEDs in the device tree
@ 2013-05-22 8:12 Linus Walleij
2013-05-22 23:14 ` Kim, Milo
2013-05-31 17:37 ` Bryan Wu
0 siblings, 2 replies; 7+ messages in thread
From: Linus Walleij @ 2013-05-22 8:12 UTC (permalink / raw)
To: linux-arm-kernel
From: Linus Walleij <linus.walleij@linaro.org>
Based on pending device tree support in the LP55xx drivers
we can add the correct LED and channel configuration from the
ux500 device tree for all HREF variants.
Cc: Milo Kim <Milo.Kim@ti.com>
Cc: Bryan Wu <cooloney@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
arch/arm/boot/dts/href.dtsi | 38 ++++++++++++++++++++++++++++++++------
1 file changed, 32 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/href.dtsi b/arch/arm/boot/dts/href.dtsi
index 62523f6..e315429 100644
--- a/arch/arm/boot/dts/href.dtsi
+++ b/arch/arm/boot/dts/href.dtsi
@@ -63,16 +63,42 @@
};
i2c at 80128000 {
- lp5521 at 0x33 {
- compatible = "lp5521";
+ lp5521 at 33 {
+ compatible = "national,lp5521";
reg = <0x33>;
+ label = "lp5521_pri";
+ clock-mode = /bits/ 8 <2>;
+ chan0 {
+ led-cur = /bits/ 8 <0x2f>;
+ max-cur = /bits/ 8 <0x5f>;
+ };
+ chan1 {
+ led-cur = /bits/ 8 <0x2f>;
+ max-cur = /bits/ 8 <0x5f>;
+ };
+ chan2 {
+ led-cur = /bits/ 8 <0x2f>;
+ max-cur = /bits/ 8 <0x5f>;
+ };
};
-
- lp5521 at 0x34 {
- compatible = "lp5521";
+ lp5521 at 34 {
+ compatible = "national,lp5521";
reg = <0x34>;
+ label = "lp5521_sec";
+ clock-mode = /bits/ 8 <2>;
+ chan0 {
+ led-cur = /bits/ 8 <0x2f>;
+ max-cur = /bits/ 8 <0x5f>;
+ };
+ chan1 {
+ led-cur = /bits/ 8 <0x2f>;
+ max-cur = /bits/ 8 <0x5f>;
+ };
+ chan2 {
+ led-cur = /bits/ 8 <0x2f>;
+ max-cur = /bits/ 8 <0x5f>;
+ };
};
-
bh1780 at 0x29 {
compatible = "rohm,bh1780gli";
reg = <0x33>;
--
1.7.11.3
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] ARM: ux500: register LP5521 LEDs in the device tree
2013-05-22 8:12 [PATCH] ARM: ux500: register LP5521 LEDs in the device tree Linus Walleij
@ 2013-05-22 23:14 ` Kim, Milo
2013-05-31 17:37 ` Bryan Wu
1 sibling, 0 replies; 7+ messages in thread
From: Kim, Milo @ 2013-05-22 23:14 UTC (permalink / raw)
To: linux-arm-kernel
> Based on pending device tree support in the LP55xx drivers
> we can add the correct LED and channel configuration from the
> ux500 device tree for all HREF variants.
>
> Cc: Milo Kim <Milo.Kim@ti.com>
> Cc: Bryan Wu <cooloney@gmail.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Milo Kim <Milo.Kim@ti.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ARM: ux500: register LP5521 LEDs in the device tree
2013-05-22 8:12 [PATCH] ARM: ux500: register LP5521 LEDs in the device tree Linus Walleij
2013-05-22 23:14 ` Kim, Milo
@ 2013-05-31 17:37 ` Bryan Wu
2013-06-03 8:18 ` Lee Jones
1 sibling, 1 reply; 7+ messages in thread
From: Bryan Wu @ 2013-05-31 17:37 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, May 22, 2013 at 1:12 AM, Linus Walleij
<linus.walleij@stericsson.com> wrote:
> From: Linus Walleij <linus.walleij@linaro.org>
>
> Based on pending device tree support in the LP55xx drivers
> we can add the correct LED and channel configuration from the
> ux500 device tree for all HREF variants.
>
> Cc: Milo Kim <Milo.Kim@ti.com>
> Cc: Bryan Wu <cooloney@gmail.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> arch/arm/boot/dts/href.dtsi | 38 ++++++++++++++++++++++++++++++++------
> 1 file changed, 32 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/href.dtsi b/arch/arm/boot/dts/href.dtsi
> index 62523f6..e315429 100644
> --- a/arch/arm/boot/dts/href.dtsi
> +++ b/arch/arm/boot/dts/href.dtsi
> @@ -63,16 +63,42 @@
> };
>
> i2c at 80128000 {
> - lp5521 at 0x33 {
> - compatible = "lp5521";
> + lp5521 at 33 {
Is this right, I guess it should be still "lp5521 at 0x33", although it's
just a name.
-Bryan
> + compatible = "national,lp5521";
> reg = <0x33>;
> + label = "lp5521_pri";
> + clock-mode = /bits/ 8 <2>;
> + chan0 {
> + led-cur = /bits/ 8 <0x2f>;
> + max-cur = /bits/ 8 <0x5f>;
> + };
> + chan1 {
> + led-cur = /bits/ 8 <0x2f>;
> + max-cur = /bits/ 8 <0x5f>;
> + };
> + chan2 {
> + led-cur = /bits/ 8 <0x2f>;
> + max-cur = /bits/ 8 <0x5f>;
> + };
> };
> -
> - lp5521 at 0x34 {
> - compatible = "lp5521";
> + lp5521 at 34 {
> + compatible = "national,lp5521";
> reg = <0x34>;
> + label = "lp5521_sec";
> + clock-mode = /bits/ 8 <2>;
> + chan0 {
> + led-cur = /bits/ 8 <0x2f>;
> + max-cur = /bits/ 8 <0x5f>;
> + };
> + chan1 {
> + led-cur = /bits/ 8 <0x2f>;
> + max-cur = /bits/ 8 <0x5f>;
> + };
> + chan2 {
> + led-cur = /bits/ 8 <0x2f>;
> + max-cur = /bits/ 8 <0x5f>;
> + };
> };
> -
> bh1780 at 0x29 {
> compatible = "rohm,bh1780gli";
> reg = <0x33>;
> --
> 1.7.11.3
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ARM: ux500: register LP5521 LEDs in the device tree
2013-05-31 17:37 ` Bryan Wu
@ 2013-06-03 8:18 ` Lee Jones
2013-06-03 17:29 ` Bryan Wu
0 siblings, 1 reply; 7+ messages in thread
From: Lee Jones @ 2013-06-03 8:18 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, 31 May 2013, Bryan Wu wrote:
> On Wed, May 22, 2013 at 1:12 AM, Linus Walleij
> <linus.walleij@stericsson.com> wrote:
> > From: Linus Walleij <linus.walleij@linaro.org>
> >
> > Based on pending device tree support in the LP55xx drivers
> > we can add the correct LED and channel configuration from the
> > ux500 device tree for all HREF variants.
> >
> > Cc: Milo Kim <Milo.Kim@ti.com>
> > Cc: Bryan Wu <cooloney@gmail.com>
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> > ---
> > arch/arm/boot/dts/href.dtsi | 38 ++++++++++++++++++++++++++++++++------
> > 1 file changed, 32 insertions(+), 6 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/href.dtsi b/arch/arm/boot/dts/href.dtsi
> > index 62523f6..e315429 100644
> > --- a/arch/arm/boot/dts/href.dtsi
> > +++ b/arch/arm/boot/dts/href.dtsi
> > @@ -63,16 +63,42 @@
> > };
> >
> > i2c at 80128000 {
> > - lp5521 at 0x33 {
> > - compatible = "lp5521";
> > + lp5521 at 33 {
>
> Is this right, I guess it should be still "lp5521 at 0x33", although it's
> just a name.
What makes you say that Bryan?
All other nodes drop the '0x', as it's implied.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ARM: ux500: register LP5521 LEDs in the device tree
2013-06-03 8:18 ` Lee Jones
@ 2013-06-03 17:29 ` Bryan Wu
2013-06-04 7:35 ` Lee Jones
0 siblings, 1 reply; 7+ messages in thread
From: Bryan Wu @ 2013-06-03 17:29 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jun 3, 2013 at 1:18 AM, Lee Jones <lee.jones@linaro.org> wrote:
> On Fri, 31 May 2013, Bryan Wu wrote:
>
>> On Wed, May 22, 2013 at 1:12 AM, Linus Walleij
>> <linus.walleij@stericsson.com> wrote:
>> > From: Linus Walleij <linus.walleij@linaro.org>
>> >
>> > Based on pending device tree support in the LP55xx drivers
>> > we can add the correct LED and channel configuration from the
>> > ux500 device tree for all HREF variants.
>> >
>> > Cc: Milo Kim <Milo.Kim@ti.com>
>> > Cc: Bryan Wu <cooloney@gmail.com>
>> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>> > ---
>> > arch/arm/boot/dts/href.dtsi | 38 ++++++++++++++++++++++++++++++++------
>> > 1 file changed, 32 insertions(+), 6 deletions(-)
>> >
>> > diff --git a/arch/arm/boot/dts/href.dtsi b/arch/arm/boot/dts/href.dtsi
>> > index 62523f6..e315429 100644
>> > --- a/arch/arm/boot/dts/href.dtsi
>> > +++ b/arch/arm/boot/dts/href.dtsi
>> > @@ -63,16 +63,42 @@
>> > };
>> >
>> > i2c at 80128000 {
>> > - lp5521 at 0x33 {
>> > - compatible = "lp5521";
>> > + lp5521 at 33 {
>>
>> Is this right, I guess it should be still "lp5521 at 0x33", although it's
>> just a name.
>
> What makes you say that Bryan?
>
> All other nodes drop the '0x', as it's implied.
>
But I still got this in this patch
" bh1780 at 0x29 {"
which is not changed. So which one should be the right?
-Bryan
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ARM: ux500: register LP5521 LEDs in the device tree
2013-06-03 17:29 ` Bryan Wu
@ 2013-06-04 7:35 ` Lee Jones
2013-06-04 17:33 ` Bryan Wu
0 siblings, 1 reply; 7+ messages in thread
From: Lee Jones @ 2013-06-04 7:35 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, 03 Jun 2013, Bryan Wu wrote:
> On Mon, Jun 3, 2013 at 1:18 AM, Lee Jones <lee.jones@linaro.org> wrote:
> > On Fri, 31 May 2013, Bryan Wu wrote:
> >
> >> On Wed, May 22, 2013 at 1:12 AM, Linus Walleij
> >> <linus.walleij@stericsson.com> wrote:
> >> > From: Linus Walleij <linus.walleij@linaro.org>
> >> >
> >> > Based on pending device tree support in the LP55xx drivers
> >> > we can add the correct LED and channel configuration from the
> >> > ux500 device tree for all HREF variants.
> >> >
> >> > Cc: Milo Kim <Milo.Kim@ti.com>
> >> > Cc: Bryan Wu <cooloney@gmail.com>
> >> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> >> > ---
> >> > arch/arm/boot/dts/href.dtsi | 38 ++++++++++++++++++++++++++++++++------
> >> > 1 file changed, 32 insertions(+), 6 deletions(-)
> >> >
> >> > diff --git a/arch/arm/boot/dts/href.dtsi b/arch/arm/boot/dts/href.dtsi
> >> > index 62523f6..e315429 100644
> >> > --- a/arch/arm/boot/dts/href.dtsi
> >> > +++ b/arch/arm/boot/dts/href.dtsi
> >> > @@ -63,16 +63,42 @@
> >> > };
> >> >
> >> > i2c at 80128000 {
> >> > - lp5521 at 0x33 {
> >> > - compatible = "lp5521";
> >> > + lp5521 at 33 {
> >>
> >> Is this right, I guess it should be still "lp5521 at 0x33", although it's
> >> just a name.
> >
> > What makes you say that Bryan?
> >
> > All other nodes drop the '0x', as it's implied.
> >
>
> But I still got this in this patch
> " bh1780 at 0x29 {"
>
> which is not changed. So which one should be the right?
The one without the '0x' is correct.
If there are any of these left over that Linus hasn't fixed yet, I'm
happy to fix.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ARM: ux500: register LP5521 LEDs in the device tree
2013-06-04 7:35 ` Lee Jones
@ 2013-06-04 17:33 ` Bryan Wu
0 siblings, 0 replies; 7+ messages in thread
From: Bryan Wu @ 2013-06-04 17:33 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Jun 4, 2013 at 12:35 AM, Lee Jones <lee.jones@linaro.org> wrote:
> On Mon, 03 Jun 2013, Bryan Wu wrote:
>
>> On Mon, Jun 3, 2013 at 1:18 AM, Lee Jones <lee.jones@linaro.org> wrote:
>> > On Fri, 31 May 2013, Bryan Wu wrote:
>> >
>> >> On Wed, May 22, 2013 at 1:12 AM, Linus Walleij
>> >> <linus.walleij@stericsson.com> wrote:
>> >> > From: Linus Walleij <linus.walleij@linaro.org>
>> >> >
>> >> > Based on pending device tree support in the LP55xx drivers
>> >> > we can add the correct LED and channel configuration from the
>> >> > ux500 device tree for all HREF variants.
>> >> >
>> >> > Cc: Milo Kim <Milo.Kim@ti.com>
>> >> > Cc: Bryan Wu <cooloney@gmail.com>
>> >> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>> >> > ---
>> >> > arch/arm/boot/dts/href.dtsi | 38 ++++++++++++++++++++++++++++++++------
>> >> > 1 file changed, 32 insertions(+), 6 deletions(-)
>> >> >
>> >> > diff --git a/arch/arm/boot/dts/href.dtsi b/arch/arm/boot/dts/href.dtsi
>> >> > index 62523f6..e315429 100644
>> >> > --- a/arch/arm/boot/dts/href.dtsi
>> >> > +++ b/arch/arm/boot/dts/href.dtsi
>> >> > @@ -63,16 +63,42 @@
>> >> > };
>> >> >
>> >> > i2c at 80128000 {
>> >> > - lp5521 at 0x33 {
>> >> > - compatible = "lp5521";
>> >> > + lp5521 at 33 {
>> >>
>> >> Is this right, I guess it should be still "lp5521 at 0x33", although it's
>> >> just a name.
>> >
>> > What makes you say that Bryan?
>> >
>> > All other nodes drop the '0x', as it's implied.
>> >
>>
>> But I still got this in this patch
>> " bh1780 at 0x29 {"
>>
>> which is not changed. So which one should be the right?
>
> The one without the '0x' is correct.
>
> If there are any of these left over that Linus hasn't fixed yet, I'm
> happy to fix.
Sure, no problem. I just found this inconsistence confused me.
Thanks,
-Bryan
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-06-04 17:33 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-22 8:12 [PATCH] ARM: ux500: register LP5521 LEDs in the device tree Linus Walleij
2013-05-22 23:14 ` Kim, Milo
2013-05-31 17:37 ` Bryan Wu
2013-06-03 8:18 ` Lee Jones
2013-06-03 17:29 ` Bryan Wu
2013-06-04 7:35 ` Lee Jones
2013-06-04 17:33 ` Bryan Wu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).