From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] ARM PJ4B: Add support for errata 4742
Date: Tue, 4 Jun 2013 19:10:30 +0100 [thread overview]
Message-ID: <20130604181030.GA18614@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <alpine.LFD.2.03.1306041348400.1200@syhkavp.arg>
On Tue, Jun 04, 2013 at 02:07:29PM -0400, Nicolas Pitre wrote:
> It could be nicer on the symbol table especially when debugging if the
> pj4b was made into a separate branch table e.g.:
>
> ENTRY(cpu_pj4b_switch_mm)
> b cpu_v7_switch_mm
> ENDPROC(cpu_pj4b_switch_mm)
>
> Otherwise the objdump output will always select the first symbol for any
> given address in alphabetical order, masking away cpu_v7_switch_mm.
That adds unnecessary runtime expense.
> Alternatively, the following could be done:
>
> #ifdef CONFIG_CPU_PJ4B
>
> .equ cpu_pj4b_switch_mm, cpu_v7_switch_mm
> .equ cpu_pj4b_set_pte_ex, cpu_v7_set_pte_ex
No, that doesn't work. I did forget a hunk from my patch though, which
needs the pj4b symbols to be global:
diff --git a/arch/arm/include/asm/glue-proc.h b/arch/arm/include/asm/glue-proc.h
index ac1dd54..8017e94 100644
--- a/arch/arm/include/asm/glue-proc.h
+++ b/arch/arm/include/asm/glue-proc.h
@@ -230,6 +230,15 @@
# endif
#endif
+#ifdef CONFIG_CPU_PJ4B
+# ifdef CPU_NAME
+# undef MULTI_CPU
+# define MULTI_CPU
+# else
+# define CPU_NAME cpu_pj4b
+# endif
+#endif
+
#ifndef MULTI_CPU
#define cpu_proc_init __glue(CPU_NAME,_proc_init)
#define cpu_proc_fin __glue(CPU_NAME,_proc_fin)
next prev parent reply other threads:[~2013-06-04 18:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-04 14:03 [PATCH v2 0/2] ARM: PJ4B: fixes for 3.10-rc Gregory CLEMENT
2013-06-04 14:03 ` [PATCH v2 1/2] ARM PJ4B: Add support for errata 4742 Gregory CLEMENT
2013-06-04 14:59 ` Russell King - ARM Linux
2013-06-04 17:19 ` Gregory CLEMENT
2013-06-04 17:35 ` Will Deacon
2013-06-04 17:37 ` Russell King - ARM Linux
2013-06-04 18:07 ` Nicolas Pitre
2013-06-04 18:10 ` Russell King - ARM Linux [this message]
2013-06-04 18:19 ` Nicolas Pitre
2013-06-04 18:21 ` Russell King - ARM Linux
2013-06-04 18:32 ` Nicolas Pitre
2013-06-04 19:04 ` Gregory CLEMENT
2013-06-04 14:03 ` [PATCH v2 2/2] ARM PJ4B: Add support for errata 4611 Gregory CLEMENT
2013-06-04 15:41 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130604181030.GA18614@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox