From mboxrd@z Thu Jan 1 00:00:00 1970 From: horms@verge.net.au (Simon Horman) Date: Wed, 5 Jun 2013 22:51:36 +0900 Subject: [PATCH 2/4] irqchip: renesas-intc-irqpin: DT binding for sense bitfield width In-Reply-To: <201306051352.52924.arnd@arndb.de> References: <1370406751-3852-1-git-send-email-horms+renesas@verge.net.au> <1370406751-3852-3-git-send-email-horms+renesas@verge.net.au> <201306051352.52924.arnd@arndb.de> Message-ID: <20130605135136.GC7451@verge.net.au> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Jun 05, 2013 at 01:52:52PM +0200, Arnd Bergmann wrote: > On Wednesday 05 June 2013, Simon Horman wrote: > > @@ -0,0 +1,13 @@ > > +DT bindings for the R-/SH-Mobile irqpin controller > > + > > +Required properties: > > + > > +- compatible: has to be "renesas,intc-irqpin" > > +- #interrupt-cells: has to be <2> > > + > > +Optional properties: > > + > > +- any properties, listed in interrupts.txt in this directory, and any standard > > + resource allocation properties > > +- sense-bitfield-width: width of a single sense bitfield in the SENSE register, > > + if different from the default 4 bits > > I think you should add documentation here about how the two interrupt cells > are to be interpreted, to allow people to fill the values from a data sheet > or board schematic. I will drop this patch from the renesas tree pending some more work on the documentation. I'll put together an updated pull request for renesas-intc-irqpin without this or the runtime-pm patch, which Magnus commented on elsewhere.