From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: Cache issues in vexpress cpu shutdown (regression in 3.10)
Date: Wed, 5 Jun 2013 20:08:53 +0100 [thread overview]
Message-ID: <20130605190853.GF18614@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20130605120539.GC32505@e102568-lin.cambridge.arm.com>
On Wed, Jun 05, 2013 at 01:05:39PM +0100, Lorenzo Pieralisi wrote:
> There is an A9 errata (fixed in r1p0) whereby CLIDR[23:21] reads as 0
> where it should read as 3'b001, so basically flush_cache_louis is not
> flushing anything. If that's the problem, either we add a generic fix
> in v7 cache assembly or we just fix it in platform code (by calling
> flush_cache_all()), since there should not be many pre-r1p0 around.
>
> Please let me know what you think.
If we're providing a flush_cache_louis() function, then it better do
what it says or be removed. So the right solution is to fix the
function rather than working around it, because over time we'll only
add more calls to flush_cache_louis() and it'll become a stumbling
block.
next prev parent reply other threads:[~2013-06-05 19:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-05 11:09 Cache issues in vexpress cpu shutdown (regression in 3.10) Jon Medhurst (Tixy)
2013-06-05 11:39 ` Russell King - ARM Linux
2013-06-05 11:50 ` Will Deacon
2013-06-05 13:45 ` Jon Medhurst (Tixy)
2013-06-05 13:58 ` Will Deacon
2013-06-05 14:13 ` Pawel Moll
2013-06-05 12:05 ` Lorenzo Pieralisi
2013-06-05 19:08 ` Russell King - ARM Linux [this message]
2013-06-06 9:21 ` Catalin Marinas
2013-06-06 9:30 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130605190853.GF18614@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).